From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vijjn-0001CR-Lw for qemu-devel@nongnu.org; Tue, 19 Nov 2013 06:45:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vijjc-0004uL-2x for qemu-devel@nongnu.org; Tue, 19 Nov 2013 06:44:59 -0500 Received: from mail-qa0-x233.google.com ([2607:f8b0:400d:c00::233]:55066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vijjb-0004u0-Vk for qemu-devel@nongnu.org; Tue, 19 Nov 2013 06:44:48 -0500 Received: by mail-qa0-f51.google.com with SMTP id o15so1842482qap.3 for ; Tue, 19 Nov 2013 03:44:47 -0800 (PST) Sender: Paolo Bonzini Message-ID: <528B4F2A.2030904@redhat.com> Date: Tue, 19 Nov 2013 12:44:42 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1383820884-29596-1-git-send-email-marcel.a@redhat.com> <1383820884-29596-8-git-send-email-marcel.a@redhat.com> In-Reply-To: <1383820884-29596-8-git-send-email-marcel.a@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-1.7 v2 7/8] pc: s/INT64_MAX/UINT64_MAX/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: peter.maydell@linaro.org, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, agraf@suse.de, qemu-devel@nongnu.org, aliguori@amazon.com, lcapitulino@redhat.com, afaerber@suse.de Il 07/11/2013 11:41, Marcel Apfelbaum ha scritto: > From: Paolo Bonzini > > It doesn't make sense for a region to be INT64_MAX in size: > memory core uses UINT64_MAX as a special value meaning > "all 64 bit" this is what was meant here. > > While this should never affect the PC system which at the moment always > has < 63 bit size, this makes us hit all kind of corner case bugs with > sub-pages, so users are probably better off if we just use UINT64_MAX > instead. > > Reported-by: Luiz Capitulino > Tested-by: Luiz Capitulino > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin Michael, is this patch (and 8/8: spapr_pci: s/INT64_MAX/UINT64_MAX/) queued for 1.7 and/or 1.8? Paolo > --- > hw/i386/pc_piix.c | 2 +- > hw/i386/pc_q35.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 4fdb7b6..8e8d354 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -115,7 +115,7 @@ static void pc_init1(QEMUMachineInitArgs *args, > > if (pci_enabled) { > pci_memory = g_new(MemoryRegion, 1); > - memory_region_init(pci_memory, NULL, "pci", INT64_MAX); > + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); > rom_memory = pci_memory; > } else { > pci_memory = NULL; > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 4c191d3..ca44e05 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -102,7 +102,7 @@ static void pc_q35_init(QEMUMachineInitArgs *args) > /* pci enabled */ > if (pci_enabled) { > pci_memory = g_new(MemoryRegion, 1); > - memory_region_init(pci_memory, NULL, "pci", INT64_MAX); > + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); > rom_memory = pci_memory; > } else { > pci_memory = NULL; >