From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47358)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Vim1Z-00087b-CI
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 09:11:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1Vim1Q-0002iI-U0
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 09:11:29 -0500
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:32829 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Vim1Q-0002iE-JB
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 09:11:20 -0500
Message-ID: <528B7190.1060009@kamp.de>
Date: Tue, 19 Nov 2013 15:11:28 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1379694292-1601-1-git-send-email-pbonzini@redhat.com>	<1379694292-1601-12-git-send-email-pbonzini@redhat.com>
	<528A310A.60607@dlhnet.de> <528A3422.1030701@kamp.de>
	<528A3C4A.4090001@redhat.com> <528B3C86.3030309@kamp.de>
	<528B41A5.1080504@redhat.com> <528B53A6.3030204@kamp.de>
	<528B561C.9070200@redhat.com> <528B5A5B.1090705@kamp.de>
	<528B65E6.7040203@redhat.com>
In-Reply-To: <528B65E6.7040203@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache
 leaves when -cpu host is used
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit@irqsave.net>

On 19.11.2013 14:21, Paolo Bonzini wrote:
> Il 19/11/2013 13:32, Peter Lieven ha scritto:
>>> +
>>> +        /* We give out APIC IDs ourselves, so force bits 31..26 even
>>> for "-cpu host".  */
>>> +        if (cs->nr_cores > 1) {
>>> +            *eax |= (cs->nr_cores - 1) << 26;
>>>            }
>>>            break;
>>>        case 5:
>> I already tried exactly this fix. Its reading index 0x0000004 for
>> increasing indexes until qemu aborts:
> Oops, it should be I guess "if ((*eax & 31) && cs->nr_cores > 1)".
Maybe, how should we continue. This should be fixed before 1.7 comes out.

Peter