From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjkid-0003Lt-0P for qemu-devel@nongnu.org; Fri, 22 Nov 2013 02:00:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjkiT-00060u-WB for qemu-devel@nongnu.org; Fri, 22 Nov 2013 01:59:58 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:49229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjkiT-00060k-5o for qemu-devel@nongnu.org; Fri, 22 Nov 2013 01:59:49 -0500 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Nov 2013 16:49:44 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 308982CE8053 for ; Fri, 22 Nov 2013 17:49:42 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rAM6VmrP62586938 for ; Fri, 22 Nov 2013 17:31:52 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rAM6nbfL006628 for ; Fri, 22 Nov 2013 17:49:37 +1100 Message-ID: <528EFE7F.7030204@linux.vnet.ibm.com> Date: Fri, 22 Nov 2013 14:49:35 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1384121021-24815-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1384121021-24815-4-git-send-email-xiawenc@linux.vnet.ibm.com> <20131119112958.GE4040@dhcp-200-207.str.redhat.com> In-Reply-To: <20131119112958.GE4040@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V5 3/5] qemu-iotests: add 058 internal snapshot export with qemu-nbd case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com 于 2013/11/19 19:29, Kevin Wolf 写道: > Am 10.11.2013 um 23:03 hat Wenchao Xia geschrieben: >> Signed-off-by: Wenchao Xia >> --- >> tests/qemu-iotests/058 | 102 ++++++++++++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/058.out | 32 ++++++++++++++ >> tests/qemu-iotests/check | 1 + >> tests/qemu-iotests/group | 1 + >> 4 files changed, 136 insertions(+), 0 deletions(-) >> create mode 100755 tests/qemu-iotests/058 >> create mode 100644 tests/qemu-iotests/058.out > > I think this should have: > > _supported_proto nbd > > Or otherwise the check in common needs to be changed. At least for me > the test failed without an error message because I didn't have a > qemu-nbd symlink in place. > > Kevin > I found a little problem: $QEMU_IMG snapshot -c sn1 "$TEST_IMG" can't work when IMGPROTO=nbd, since in common.rc the image was not exported as raw: if [ $IMGPROTO = "nbd" ]; then eval "$QEMU_NBD -v -t -b 127.0.0.1 -p 10810 $TEST_IMG_FILE &" QEMU_NBD_PID=$! sleep 1 # FIXME: qemu-nbd needs to be listening before we continue fi So later the test case think $TEST_IMG as a raw image. All case used $QEMU_IMG snapshot will fail, such as 015? Do you think this is a bug? Instead if change common.rc to exported as raw(I am not sure whether it is done on purpose), how about add a check called: _required_util in common.rc?