From: Marek Vasut <marek.vasut@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static
Date: Thu, 10 Jan 2019 14:07:20 +0000 [thread overview]
Message-ID: <52902326-baf8-d6b5-52e3-0442fdaebc87@gmail.com> (raw)
On 1/10/19 3:07 PM, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/gpio/gpio-pca953x.c:292:28: warning:
> symbol 'pca953x_i2c_regmap' was not declared. Should it be static?
>
> Fixes: 49427232764d ("gpio: pca953x: Perform basic regmap conversion")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Nice, thanks.
Reviewed-by: Marek Vasut <marex@denx.de>
For future reference, how did you run sparse to detect this ?
> ---
> drivers/gpio/gpio-pca953x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 83617fd..0dc9641 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -289,7 +289,7 @@ static bool pca953x_volatile_register(struct device *dev, unsigned int reg)
> return pca953x_check_register(chip, reg, bank);
> }
>
> -const struct regmap_config pca953x_i2c_regmap = {
> +static const struct regmap_config pca953x_i2c_regmap = {
> .reg_bits = 8,
> .val_bits = 8,
>
>
>
--
Best regards,
Marek Vasut
next reply other threads:[~2019-01-10 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 14:07 Marek Vasut [this message]
2019-01-10 14:07 ` [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static Wei Yongjun
2019-01-11 1:50 ` weiyongjun (A)
2019-01-11 2:33 ` Marek Vasut
2019-01-11 5:45 ` weiyongjun (A)
2019-01-11 8:17 ` Linus Walleij
2019-01-11 11:31 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52902326-baf8-d6b5-52e3-0442fdaebc87@gmail.com \
--to=marek.vasut@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.