From: Thomas Monjalon <thomas@monjalon.net>
To: Harman Kalra <hkalra@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
John McNamara <john.mcnamara@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
"barbette@kth.se" <barbette@kth.se>,
Yongseok Koh <yskoh@mellanox.com>,
"viacheslavo@mellanox.com" <viacheslavo@mellanox.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] examples/rxtx_callbacks: fix HW timestamp enable
Date: Tue, 30 Jul 2019 09:11:10 +0200 [thread overview]
Message-ID: <5296418.QIOJa9lHfJ@xps> (raw)
In-Reply-To: <20190730065702.GA23822@outlook.office365.com>
30/07/2019 08:57, Harman Kalra:
> On Tue, Jul 30, 2019 at 12:18:59AM +0200, Thomas Monjalon wrote:
> > External Email
> >
> > ----------------------------------------------------------------------
> > 25/07/2019 17:51, Harman Kalra:
> > > Offloafing Rx timestamp is a device capability than queue capability.
> >
> > Why is it a device capability and not a queue capability?
>
> 1. Since all PMDs doesn't implements per queue offload capabilities but
> supports RX timestamping and also since rx_offload_capa includes all
> rx_queue_offload_capa's. So we moved the DEV_RX_OFFLOAD_TIMESTAMP
> configuration setting to device from queue, as its a test application
> and should work with all PMDs.
>
> 2. Or we can have a test in this application, i.e. if PMD has
> rx_queue_offload_capa implemented go with per queue configuration else
> make it a device configuration.
>
> If OK with this first approach, we will send V2 with reworded commit message
> explaining the reason as above.
I'm fine with any logic if
1/ it works with all PMDs
2/ the real reason is explained
next prev parent reply other threads:[~2019-07-30 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 15:51 [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix HW timestamp enable Harman Kalra
2019-07-27 17:14 ` Jerin Jacob Kollanukkaran
2019-07-27 20:34 ` [dpdk-dev] [PATCH v2 1/2] net/octeontx2: fix ptp performance issue Harman Kalra
2019-07-27 20:34 ` [dpdk-dev] [PATCH v2 2/2] net/octeontx2: support read clock API Harman Kalra
2019-07-29 22:18 ` [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix HW timestamp enable Thomas Monjalon
2019-07-30 6:57 ` [dpdk-dev] [EXT] " Harman Kalra
2019-07-30 7:11 ` Thomas Monjalon [this message]
2019-07-30 7:46 ` [dpdk-dev] [PATCH v2] " Harman Kalra
2019-07-30 9:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5296418.QIOJa9lHfJ@xps \
--to=thomas@monjalon.net \
--cc=barbette@kth.se \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hkalra@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=viacheslavo@mellanox.com \
--cc=xiaoyun.li@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.