From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 02/31] ARM: tegra: document reset properties in DT bindings Date: Tue, 03 Dec 2013 11:48:33 -0700 Message-ID: <529E2781.5020504@wwwdotorg.org> References: <1384548866-13141-1-git-send-email-swarren@wwwdotorg.org> <1384548866-13141-3-git-send-email-swarren@wwwdotorg.org> <20131129122348.GO22771@ulmo.nvidia.com> <529B88C9.60804@wwwdotorg.org> <20131202090852.GD17834@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131202090852.GD17834-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Stephen Warren , treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 12/02/2013 02:08 AM, Thierry Reding wrote: > On Sun, Dec 01, 2013 at 12:06:49PM -0700, Stephen Warren wrote: >> On 11/29/2013 05:23 AM, Thierry Reding wrote: >>> On Fri, Nov 15, 2013 at 01:53:57PM -0700, Stephen Warren wrote: >>> [...] >>>> diff --git >>>> a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt >>>> >>>> b/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt >>> >>>> >> [...] >>>> + - resets : Must contain an entry for each entry in >>>> reset-names. + See ../reset/reset.txt for details. + - >>>> reset-names : Must include the following entries: + - dc >>> >>> For consistency with this, the clock-names entry for the first >>> clock in this node should then be "dc" as well. >> >> The dc driver gets the clock by name, so this isn't a >> requirement. > > Right, but like I've said in another reply, I'd very much like for > this to be fixed up so we don't have to mess around with > per-instance names for clocks. So instead of naming the first clock > in the display controller node "disp", we could rename it to "dc" > for consistency with the reset bindings. I assume you're now OK with not changing the clock names, given my explanation? From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 03 Dec 2013 11:48:33 -0700 Subject: [PATCH 02/31] ARM: tegra: document reset properties in DT bindings In-Reply-To: <20131202090852.GD17834@ulmo.nvidia.com> References: <1384548866-13141-1-git-send-email-swarren@wwwdotorg.org> <1384548866-13141-3-git-send-email-swarren@wwwdotorg.org> <20131129122348.GO22771@ulmo.nvidia.com> <529B88C9.60804@wwwdotorg.org> <20131202090852.GD17834@ulmo.nvidia.com> Message-ID: <529E2781.5020504@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/02/2013 02:08 AM, Thierry Reding wrote: > On Sun, Dec 01, 2013 at 12:06:49PM -0700, Stephen Warren wrote: >> On 11/29/2013 05:23 AM, Thierry Reding wrote: >>> On Fri, Nov 15, 2013 at 01:53:57PM -0700, Stephen Warren wrote: >>> [...] >>>> diff --git >>>> a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt >>>> >>>> b/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt >>> >>>> >> [...] >>>> + - resets : Must contain an entry for each entry in >>>> reset-names. + See ../reset/reset.txt for details. + - >>>> reset-names : Must include the following entries: + - dc >>> >>> For consistency with this, the clock-names entry for the first >>> clock in this node should then be "dc" as well. >> >> The dc driver gets the clock by name, so this isn't a >> requirement. > > Right, but like I've said in another reply, I'd very much like for > this to be fixed up so we don't have to mess around with > per-instance names for clocks. So instead of naming the first clock > in the display controller node "disp", we could rename it to "dc" > for consistency with the reset bindings. I assume you're now OK with not changing the clock names, given my explanation?