From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information Date: Mon, 9 Dec 2013 14:56:20 +0200 Message-ID: <52A5BDF4.2070304@ti.com> References: <1386160133-24026-1-git-send-email-tomi.valkeinen@ti.com> <1386160133-24026-16-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sweC9I40gClxwW27U3q7MX5Ud9fwMgckI" Return-path: In-Reply-To: Sender: linux-omap-owner@vger.kernel.org To: Javier Martinez Canillas Cc: "linux-omap@vger.kernel.org" , linux-fbdev@vger.kernel.org, "devicetree@vger.kernel.org" , Archit Taneja , Darren Etheridge , Tony Lindgren List-Id: devicetree@vger.kernel.org --sweC9I40gClxwW27U3q7MX5Ud9fwMgckI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2013-12-06 10:57, Javier Martinez Canillas wrote: >> + tfp410: encoder@0 { >> + compatible =3D "ti,tfp410"; >> + gpios =3D <&gpio1 0 0>; /* 0, power-down */ >> + >=20 > Please use the constants from include/dt-bindings/ instead of magic > numbers, i.e: >=20 > gpios =3D <&gpio1 0 GPIO_ACTIVE_HIGH>; /* 0, power-down */ Thanks, fixed now (for all .dts files) However... The TFP410 gpio is "power-down". I think we should actually mark it as GPIO_ACTIVE_LOW, as setting it to 0 powers down the device. Tomi --sweC9I40gClxwW27U3q7MX5Ud9fwMgckI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSpb30AAoJEPo9qoy8lh71nU0QAKXbwnH5YsMsNEZwCQWu6gTt J4QMj9/LP/Dcm7PMdT7Y+Acuqnen4v2zYbNeiYflOPlT02XAmk+QqmMTUeI74R6o l1xlqXD4NZbAy7m3BQERQFQ3uBTmrKdtnlePKm/4MpXN6d0Sdxbg1CYiFv7AetaK U5ES0+N6CiCb5dq1AlaAG/qAxMu28EiJQ2xRyrmThHM5jDsg29N4+zY1+Io/nlqj D0G/9tSUUQdLzKmPzLbDSaSnX8MAYuh8DqD3gIoQZfbaqSmTPwmwk2iIuyEQtRCs bpNPGP9lSkvqLWQK6o6j2eyNv/fmcRlD4nbCJhTyAcl39kWhtfO+W5Uh7zXtgioG mgeWiLozKbRLwtwfwrDIs2C1RzuIzrfxRoG7pQLzuMTU8dFtru1yhLwe3UfZkQPt B1RAc77QsbvaAfZ9UKX1/iy8JOEqOj2FyI6+QgaBVrcHduTKPOU9Lq1BZYtgnwqg WKQtqY+Qr8+HynjUg3eaH0wIIP+s2ZswUq34pFpVP3LuA8u9tqwkOinVaPDpLfRt p4FyOxMCMsqyBrGbnSyCoyCtQaGw2lc7jSgugDUBPQSX6syssxocgFBKD8NCA6fO Cp/0obq5q+7TSwXD4OlFdIAfySaN/FeGXeITnupGQ7jNBt/T73uN/zFZClvysTdl fPQHb59QlPhsA1W70Mev =1HkV -----END PGP SIGNATURE----- --sweC9I40gClxwW27U3q7MX5Ud9fwMgckI-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Mon, 09 Dec 2013 12:56:20 +0000 Subject: Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information Message-Id: <52A5BDF4.2070304@ti.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="sweC9I40gClxwW27U3q7MX5Ud9fwMgckI" List-Id: References: <1386160133-24026-1-git-send-email-tomi.valkeinen@ti.com> <1386160133-24026-16-git-send-email-tomi.valkeinen@ti.com> In-Reply-To: To: Javier Martinez Canillas Cc: "linux-omap@vger.kernel.org" , linux-fbdev@vger.kernel.org, "devicetree@vger.kernel.org" , Archit Taneja , Darren Etheridge , Tony Lindgren --sweC9I40gClxwW27U3q7MX5Ud9fwMgckI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2013-12-06 10:57, Javier Martinez Canillas wrote: >> + tfp410: encoder@0 { >> + compatible =3D "ti,tfp410"; >> + gpios =3D <&gpio1 0 0>; /* 0, power-down */ >> + >=20 > Please use the constants from include/dt-bindings/ instead of magic > numbers, i.e: >=20 > gpios =3D <&gpio1 0 GPIO_ACTIVE_HIGH>; /* 0, power-down */ Thanks, fixed now (for all .dts files) However... The TFP410 gpio is "power-down". I think we should actually mark it as GPIO_ACTIVE_LOW, as setting it to 0 powers down the device. Tomi --sweC9I40gClxwW27U3q7MX5Ud9fwMgckI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSpb30AAoJEPo9qoy8lh71nU0QAKXbwnH5YsMsNEZwCQWu6gTt J4QMj9/LP/Dcm7PMdT7Y+Acuqnen4v2zYbNeiYflOPlT02XAmk+QqmMTUeI74R6o l1xlqXD4NZbAy7m3BQERQFQ3uBTmrKdtnlePKm/4MpXN6d0Sdxbg1CYiFv7AetaK U5ES0+N6CiCb5dq1AlaAG/qAxMu28EiJQ2xRyrmThHM5jDsg29N4+zY1+Io/nlqj D0G/9tSUUQdLzKmPzLbDSaSnX8MAYuh8DqD3gIoQZfbaqSmTPwmwk2iIuyEQtRCs bpNPGP9lSkvqLWQK6o6j2eyNv/fmcRlD4nbCJhTyAcl39kWhtfO+W5Uh7zXtgioG mgeWiLozKbRLwtwfwrDIs2C1RzuIzrfxRoG7pQLzuMTU8dFtru1yhLwe3UfZkQPt B1RAc77QsbvaAfZ9UKX1/iy8JOEqOj2FyI6+QgaBVrcHduTKPOU9Lq1BZYtgnwqg WKQtqY+Qr8+HynjUg3eaH0wIIP+s2ZswUq34pFpVP3LuA8u9tqwkOinVaPDpLfRt p4FyOxMCMsqyBrGbnSyCoyCtQaGw2lc7jSgugDUBPQSX6syssxocgFBKD8NCA6fO Cp/0obq5q+7TSwXD4OlFdIAfySaN/FeGXeITnupGQ7jNBt/T73uN/zFZClvysTdl fPQHb59QlPhsA1W70Mev =1HkV -----END PGP SIGNATURE----- --sweC9I40gClxwW27U3q7MX5Ud9fwMgckI--