Re: [PATCH 2/4] Accept environment variables on the command line for Xen.

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

On 12.12.2013 18:12, Andrey Borzenkov wrote:
> В Thu, 12 Dec 2013 17:13:13 +0100
> "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com> пишет:
> 
>> - Many platforms add their own command line arguments even if user didn't
>> ask for it. Those shouldn't interfere. In your patch root=sda1 from xen
>> will either be lost or will clobber GRUB root.
> 
> My be we could adopt current Linux convention and prefix variables for
> GRUB with grub.foo=xxx (stripping "grub." prefix). I do not know whether
> it could have compatibility implications for current code though.
> 
> The reasoning is, it would allow overwriting variables very early
> without need for scripting that is available only after normal is
> loaded.
> 
My response was terse and it seems that you misunderstood it, sorry. I
meant more along the lines that define:
cmdline.# as number of arguments
cmdline.1,..., cmdline.N are the raw arguments
cmdline.var.<name> are parsed variants of <name>=<value>

E.g. If the commandline is "root=/dev/sda1 ro"
Then
cmdline.#=2
cmdline.1=root=/dev/sda1
cmdline.2=ro
cmdline.var.root=/dev/sda1

Would that be satisfactory for your usecases? What are the usecases?
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]