From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [RFC PATCH 09/10] libxl: Add VTPOWER,
 VTREBOOT and VTPING
Date: Fri, 13 Dec 2013 00:58:46 +0000
Message-ID: <52AA5BC6.4080105@citrix.com>
References: <1386875718-28166-1-git-send-email-dslutz@terremark.com>
	<1386875718-28166-10-git-send-email-dslutz@terremark.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1386875718-28166-10-git-send-email-dslutz@terremark.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, Eddie Dong <eddie.dong@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 12/12/2013 19:15, Don Slutz wrote:
> From: Don Slutz <dslutz@verizon.com>
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
>  tools/libxl/libxl.c         | 12 ++++++++++++
>  tools/libxl/libxl_types.idl |  3 +++
>  tools/libxl/xl_cmdtable.c   |  2 +-
>  xen/arch/x86/domctl.c       | 34 ++++++++++++++++++++++++++++++++++
>  xen/include/public/domctl.h |  3 +++
>  5 files changed, 53 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index fd8b988..1ec8484 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -5057,6 +5057,18 @@ int libxl_send_trigger(libxl_ctx *ctx, uint32_t domid,
>          rc = xc_domain_send_trigger(ctx->xch, domid,
>                                      XEN_DOMCTL_SENDTRIGGER_SLEEP, vcpuid);
>          break;
> +    case LIBXL_TRIGGER_VTPOWER:
> +        rc = xc_domain_send_trigger(ctx->xch, domid,
> +                                    XEN_DOMCTL_SENDTRIGGER_VTPOWER, vcpuid);
> +        break;
> +    case LIBXL_TRIGGER_VTREBOOT:
> +        rc = xc_domain_send_trigger(ctx->xch, domid,
> +                                    XEN_DOMCTL_SENDTRIGGER_VTREBOOT, vcpuid);
> +        break;
> +    case LIBXL_TRIGGER_VTPING:
> +        rc = xc_domain_send_trigger(ctx->xch, domid,
> +                                    XEN_DOMCTL_SENDTRIGGER_VTPING, vcpuid);
> +        break;
>      case LIBXL_TRIGGER_NMI:
>          rc = xc_domain_send_trigger(ctx->xch, domid,
>                                      XEN_DOMCTL_SENDTRIGGER_NMI, vcpuid);
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index 71ba64e..80a8ee8 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -105,6 +105,9 @@ libxl_trigger = Enumeration("trigger", [
>      (4, "INIT"),
>      (5, "RESET"),
>      (6, "S3RESUME"),
> +    (7, "VTPOWER"),
> +    (8, "VTREBOOT"),
> +    (9, "VTPING"),
>      ])
>  
>  libxl_tsc_mode = Enumeration("tsc_mode", [
> diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c
> index ebe0220..98db8ae 100644
> --- a/tools/libxl/xl_cmdtable.c
> +++ b/tools/libxl/xl_cmdtable.c
> @@ -290,7 +290,7 @@ struct cmd_spec cmd_table[] = {
>      { "trigger",
>        &main_trigger, 0, 1,
>        "Send a trigger to a domain",
> -      "<Domain> <nmi|reset|init|power|sleep|s3resume> [<VCPU>]",
> +      "<Domain> <nmi|reset|init|power|sleep|s3resume|vtpower|vtreboot|vtping> [<VCPU>]",
>      },
>      { "sysrq",
>        &main_sysrq, 0, 1,
> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
> index ef6c140..8b77ce2 100644
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -23,6 +23,7 @@
>  #include <xen/paging.h>
>  #include <asm/irq.h>
>  #include <asm/hvm/hvm.h>
> +#include <asm/hvm/vmport.h>
>  #include <asm/hvm/support.h>
>  #include <asm/hvm/cacheattr.h>
>  #include <asm/processor.h>
> @@ -577,6 +578,39 @@ long arch_do_domctl(
>          }
>          break;
>  
> +        case XEN_DOMCTL_SENDTRIGGER_VTPOWER:
> +        {
> +            ret = -EINVAL;
> +            if ( is_hvm_domain(d) )

Surely "is_vmware_domain(d)" is the appropriate check here?

> +            {
> +                ret = 0;
> +                vmport_ctrl_send(&d->arch.hvm_domain, "OS_Halt", 1);
> +            }
> +        }
> +        break;
> +
> +        case XEN_DOMCTL_SENDTRIGGER_VTREBOOT:
> +        {
> +            ret = -EINVAL;
> +            if ( is_hvm_domain(d) )
> +            {
> +                ret = 0;
> +                vmport_ctrl_send(&d->arch.hvm_domain, "OS_Reboot", 2);
> +            }
> +        }
> +        break;
> +
> +        case XEN_DOMCTL_SENDTRIGGER_VTPING:
> +        {
> +            ret = -EINVAL;
> +            if ( is_hvm_domain(d) )
> +            {
> +                ret = 0;
> +                vmport_ctrl_send(&d->arch.hvm_domain, "ping", 3);

POWER and REBOOT I can understand, but what is the expected actions from
PING ?

~Andrew

> +            }
> +        }
> +        break;
> +
>          default:
>              ret = -ENOSYS;
>          }
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 01a3652..d71d57c 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -454,6 +454,9 @@ DEFINE_XEN_GUEST_HANDLE(xen_domctl_real_mode_area_t);
>  #define XEN_DOMCTL_SENDTRIGGER_INIT   2
>  #define XEN_DOMCTL_SENDTRIGGER_POWER  3
>  #define XEN_DOMCTL_SENDTRIGGER_SLEEP  4
> +#define XEN_DOMCTL_SENDTRIGGER_VTPOWER  5
> +#define XEN_DOMCTL_SENDTRIGGER_VTREBOOT 6
> +#define XEN_DOMCTL_SENDTRIGGER_VTPING   7
>  struct xen_domctl_sendtrigger {
>      uint32_t  trigger;  /* IN */
>      uint32_t  vcpu;     /* IN */