All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v3 3/6] net_sched: mirred: remove action when the target device is gone
Date: Fri, 13 Dec 2013 07:07:49 -0500	[thread overview]
Message-ID: <52AAF895.8090805@mojatatu.com> (raw)
In-Reply-To: <1386913673-8210-4-git-send-email-xiyou.wangcong@gmail.com>

On 12/13/13 00:47, Cong Wang wrote:
> When the target device is removed, the mirred action is
> still there but with the dev pointer setting to NULL.
> This makes the output from 'tc filter' ugly. There is no
> reason to keep it.
>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
>   include/net/tc_act/tc_mirred.h |  4 +++-
>   net/sched/act_mirred.c         | 15 +++++++--------
>   2 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/include/net/tc_act/tc_mirred.h b/include/net/tc_act/tc_mirred.h
> index cfe2943..2026cf6 100644
> --- a/include/net/tc_act/tc_mirred.h
> +++ b/include/net/tc_act/tc_mirred.h
> @@ -7,9 +7,11 @@ struct tcf_mirred {
>   	struct tcf_common	common;
>   	int			tcfm_eaction;
>   	int			tcfm_ifindex;
> -	int			tcfm_ok_push;
> +	unsigned int		tcfm_ok_push:1;
> +	unsigned int		tcfm_bind:1;

What has the above cleverness got to do with anything you intended?

cheers,
jamal

  reply	other threads:[~2013-12-13 12:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13  5:47 [PATCH net-next v3 0/6] net_sched: some cleanup and improvments Cong Wang
2013-12-13  5:47 ` [PATCH net-next v3 1/6] net_sched: remove get_stats from tc_action_ops Cong Wang
2013-12-13 10:21   ` David Laight
2013-12-13 18:33     ` Cong Wang
2013-12-13 21:27       ` Jamal Hadi Salim
2013-12-13 21:34         ` Cong Wang
2013-12-13 21:40           ` Jamal Hadi Salim
2013-12-13 21:50             ` Cong Wang
2013-12-13 22:19               ` Jamal Hadi Salim
2013-12-13 23:23                 ` David Miller
2013-12-14  2:59                   ` Jamal Hadi Salim
2013-12-14  5:15                     ` David Miller
2013-12-14 12:22                       ` Jamal Hadi Salim
2013-12-15  3:26                         ` David Miller
2013-12-13 23:21         ` David Miller
2013-12-13 12:05   ` Jamal Hadi Salim
2013-12-13 18:38     ` Cong Wang
2013-12-13 21:29       ` Jamal Hadi Salim
2013-12-13  5:47 ` [PATCH net-next v3 2/6] net_sched: act: use standard struct list_head Cong Wang
2013-12-13 12:08   ` Jamal Hadi Salim
2013-12-13 18:48     ` Cong Wang
2013-12-13 21:29       ` Jamal Hadi Salim
2013-12-13 21:35         ` Cong Wang
2013-12-13  5:47 ` [PATCH net-next v3 3/6] net_sched: mirred: remove action when the target device is gone Cong Wang
2013-12-13 12:07   ` Jamal Hadi Salim [this message]
2013-12-13 12:12     ` David Laight
2013-12-13 18:52       ` Cong Wang
2013-12-13  5:47 ` [PATCH net-next v3 4/6] net_sched: cls: refactor out struct tcf_ext_map Cong Wang
2013-12-13  5:47 ` [PATCH net-next v3 5/6] net_sched: init struct tcf_hashinfo at register time Cong Wang
2013-12-13  5:47 ` [PATCH net-next v3 6/6] net_sched: convert tcf_hashinfo to hlist and use rcu Cong Wang
2013-12-13  6:48   ` Eric Dumazet
2013-12-13 21:44     ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AAF895.8090805@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.