From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [RFC PATCH 01/10] smbios: Add "plus VMware-Tools"
 to HVM_XS_SYSTEM_PRODUCT_NAME.
Date: Fri, 13 Dec 2013 13:03:08 -0500
Message-ID: <52AB4BDC.4040204@terremark.com>
References: <1386875718-28166-1-git-send-email-dslutz@terremark.com>	<1386875718-28166-2-git-send-email-dslutz@terremark.com>
	<20131212193559.GA12245@aepfle.de> <52AA3394.9070209@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52AA3394.9070209@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Don Slutz <dslutz@verizon.com>
Cc: Olaf Hering <olaf@aepfle.de>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Jun Nakajima <jun.nakajima@intel.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 12/12/13 17:07, Andrew Cooper wrote:
> On 12/12/2013 19:35, Olaf Hering wrote:
>> On Thu, Dec 12, Don Slutz wrote:
>>
>>> -    s = xenstore_read(HVM_XS_SYSTEM_PRODUCT_NAME, "HVM domU");
>>> +    s = xenstore_read(HVM_XS_SYSTEM_PRODUCT_NAME, "HVM domU plus VMware-Tools");
>> This will break other code which checks for the current string.
>> (/sys/class/dmi/id/product_name)
>>
>> Olaf
That is true, however since this is a xenstore_read, this is the default value.  I do not know of any code that checks for just "HVM domU", and it would break on any system that uses xenstore to change this to something else.
> Furthermore, the whole point of this is so the toolstack can write the
> xenstore key
>
> /local/domain/$DOMID/bios-strings/system-product-name
>
> with a custom value which will be written into the SMBios table.
True.  The default tool stack (xl) does not change this, and so I was looking into a simple way to let xl users enable this.  I can add a xenstore_read of "platform/vmware_hw", "0" (set in patch #4) to make it conditional.  This is some what optional in that VMware's stated way of using this is only after CPUID fails.
> The toolstack itself should have a big "pretend to be vmware" flag for a
> domain.
And Verizon's does and so we do not need this change.  Maybe I should have just added this to some documentation.

    -Don Slutz
> ~Andrew