From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [RFC PATCH 02/10] Add VMware HVM params
Date: Fri, 13 Dec 2013 13:12:09 -0500
Message-ID: <52AB4DF9.4010308@terremark.com>
References: <1386875718-28166-1-git-send-email-dslutz@terremark.com>	<1386875718-28166-3-git-send-email-dslutz@terremark.com>
	<52AA3982.8090005@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52AA3982.8090005@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, Jun Nakajima <jun.nakajima@intel.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 12/12/13 17:32, Andrew Cooper wrote:
> On 12/12/2013 19:15, Don Slutz wrote:
>> From: Don Slutz <dslutz@verizon.com>
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
>> ---
>>   xen/include/public/hvm/params.h | 11 ++++++++++-
>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h
>> index 517a184..c571a1e 100644
>> --- a/xen/include/public/hvm/params.h
>> +++ b/xen/include/public/hvm/params.h
>> @@ -145,6 +145,15 @@
>>   /* SHUTDOWN_* action in case of a triple fault */
>>   #define HVM_PARAM_TRIPLE_FAULT_REASON 31
>>   
>> -#define HVM_NR_PARAMS          32
>> +/* Params for VMware */
>> +#define HVM_PARAM_VMWARE_HW                 32
>> +#define HVM_PARAM_VMPORT_LOGMASK            33
>> +#define HVM_PARAM_VMPORT_STATUS             34
>> +#define HVM_PARAM_VMPORT_BUILD_NUMBER_TIME  35
>> +#define HVM_PARAM_VMPORT_BUILD_NUMBER_VALUE 36
>> +#define HVM_PARAM_VMPORT_RESET_TIME         37
>> +
>> +#define HVM_NR_PARAMS          38
>> +
>>   
>>   #endif /* __XEN_PUBLIC_HVM_PARAMS_H__ */
> STATUS at the very least sounds like it should be read-only from domains?
It does not need to be.  It is only written to, never read by the code.  So far I have only used it as a check (debugging help) while doing manual testing, and a simple program that just outputs the hex value was what I used.  At this point, it and the code to modify it could be removed.
    -Don
>
> You might want/need some extra logic in do_hvm_op().
>
> ~Andrew
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel