From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [RFC PATCH 02/10] Add VMware HVM params Date: Fri, 13 Dec 2013 13:13:30 -0500 Message-ID: <52AB4E4A.8040902@terremark.com> References: <1386875718-28166-1-git-send-email-dslutz@terremark.com> <1386875718-28166-3-git-send-email-dslutz@terremark.com> <52AAF50F020000780010CEB9@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VrXFU-0005UI-TW for xen-devel@lists.xenproject.org; Fri, 13 Dec 2013 18:14:05 +0000 In-Reply-To: <52AAF50F020000780010CEB9@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Don Slutz Cc: Keir Fraser , Ian Campbell , Stefano Stabellini , Ian Jackson , Eddie Dong , Jun Nakajima , xen-devel , Boris Ostrovsky , Suravee Suthikulpanit List-Id: xen-devel@lists.xenproject.org On 12/13/13 05:52, Jan Beulich wrote: >>>> On 12.12.13 at 20:15, Don Slutz wrote: >> --- a/xen/include/public/hvm/params.h >> +++ b/xen/include/public/hvm/params.h >> @@ -145,6 +145,15 @@ >> /* SHUTDOWN_* action in case of a triple fault */ >> #define HVM_PARAM_TRIPLE_FAULT_REASON 31 >> >> -#define HVM_NR_PARAMS 32 >> +/* Params for VMware */ >> +#define HVM_PARAM_VMWARE_HW 32 >> +#define HVM_PARAM_VMPORT_LOGMASK 33 >> +#define HVM_PARAM_VMPORT_STATUS 34 >> +#define HVM_PARAM_VMPORT_BUILD_NUMBER_TIME 35 >> +#define HVM_PARAM_VMPORT_BUILD_NUMBER_VALUE 36 >> +#define HVM_PARAM_VMPORT_RESET_TIME 37 >> + >> +#define HVM_NR_PARAMS 38 >> + >> >> #endif /* __XEN_PUBLIC_HVM_PARAMS_H__ */ > Both for reviewing purposes and from a consistency pov this > should be in a single patch together with the hypervisor side > implementation. Thanks, I will move it there. Still learning the "split a change into set of patches". -Don Slutz > Jan >