From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZFD-00077y-Cz for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:22:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrZF8-0007aX-Gi for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:21:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZF8-0007aT-6o for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:21:50 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDKLnqV015220 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 15:21:49 -0500 Message-ID: <52AB6C5C.30404@redhat.com> Date: Fri, 13 Dec 2013 13:21:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1386954633-28905-1-git-send-email-mreitz@redhat.com> <1386954633-28905-14-git-send-email-mreitz@redhat.com> In-Reply-To: <1386954633-28905-14-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qAgCTbmMJX1Td3hUebo1CrJflvbXo0Cea" Subject: Re: [Qemu-devel] [PATCH v5 13/22] qemu-iotests: Fix output of test 051 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qAgCTbmMJX1Td3hUebo1CrJflvbXo0Cea Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/13/2013 10:10 AM, Max Reitz wrote: > Allowing nested file formats now results in e.g. qcow2 BlockDriverState= s > never being directly passed to bdrv_open_common() from bdrv_file_open()= , > but instead being handed through bdrv_open(). This changes the error > message when trying to give a filename to qcow2, i.e. trying to use it > as a driver for the protocol level. Shouldn't this be squashed with the patch that changed the error message, so that a bisection doesn't hit the broken test? Besides, touching the testsuite at the same time as the rest of the code base shows that you are aware of the changes caused by your code. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qAgCTbmMJX1Td3hUebo1CrJflvbXo0Cea Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSq2xcAAoJEKeha0olJ0Nq9jkH/3PsPppNBjhcYBzIIxSmeAAw e7jwdT0oA452e2TqZpp5aAT7b8thbB0/SdCl90zXJ3gx+e3Q/pMW7ShwwHM3YN6D 3y35cyabhLysiqLIfdoANju2DcHu2QIw6S0trUfjfHHsp6W4/zMGKBQAdoHs5Qi0 mnDQORI3Ck8IMm+o1bWfmcW0z9v3HkwJ2q9abCUe1zgjq7DMLjgHPsYg5HsGCHyN sgY1p6Ug1WjVssA3NKevTi5wkyu0NaPt/iUXBRz3z38R2hpXWF5y8B7AVzC/BnE/ +27F1645nNet33jxPBYo1lCkpAAOuC1WJ2EXP33Xn+QxgsV6UDVDOz9O5X9U4NA= =jouv -----END PGP SIGNATURE----- --qAgCTbmMJX1Td3hUebo1CrJflvbXo0Cea--