From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsRfG-00045o-W2 for qemu-devel@nongnu.org; Mon, 16 Dec 2013 01:28:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsRf8-0006Vh-Id for qemu-devel@nongnu.org; Mon, 16 Dec 2013 01:28:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsRf8-0006Vd-9w for qemu-devel@nongnu.org; Mon, 16 Dec 2013 01:28:18 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBG6SHAU009725 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Dec 2013 01:28:17 -0500 Message-ID: <52AE9D77.20202@redhat.com> Date: Mon, 16 Dec 2013 14:28:07 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1385444708-19439-1-git-send-email-famz@redhat.com> <1385444708-19439-5-git-send-email-famz@redhat.com> <52ABCC09.3070000@redhat.com> In-Reply-To: <52ABCC09.3070000@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 4/6] commit: support commit active layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, stefanha@redhat.com On 2013=E5=B9=B412=E6=9C=8814=E6=97=A5 11:10, Eric Blake wrote: > On 11/25/2013 10:45 PM, Fam Zheng wrote: >> If active is top, it will be mirrored to base, (with block/mirror.c >> code), then the image is switched when user completes the block job. >> >> QMP documentation is updated. >> >> Signed-off-by: Fam Zheng >> --- > >> +++ b/qapi-schema.json >> @@ -1967,9 +1967,11 @@ >> # >> # @top: The file name of the backing image within the i= mage chain, >> # which contains the topmost data to be committed= down. >> -# Note, the active layer as 'top' is currently uns= upported. >> # >> # If top =3D=3D base, that is an error. >> +# If top =3D=3D active, the job will not be comple= ted by itself, >> +# user needs to complete the job with the block-jo= b-complete >> +# command after getting the ready event. (Since 1.= 8) > > s/1.8/2.0/ OK, thanks. Kevin, if you agree with my explanation on your comment, would you fix=20 this while applying? > > What happens if the user does block-job-cancel instead of > block-job-complete? With drive-mirror, that leaves the mirrored drive > as a nice copy at the point in time of the cancel. I guess with commit= , > a cancel just aborts the commit and does not change which image is top. > True.