From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsRjY-00059V-Vn for qemu-devel@nongnu.org; Mon, 16 Dec 2013 01:32:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsRjT-0007py-0v for qemu-devel@nongnu.org; Mon, 16 Dec 2013 01:32:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsRjS-0007pt-O1 for qemu-devel@nongnu.org; Mon, 16 Dec 2013 01:32:46 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBG6Wj2Y028347 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Dec 2013 01:32:46 -0500 Message-ID: <52AE9E84.6090501@redhat.com> Date: Mon, 16 Dec 2013 14:32:36 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1385444708-19439-1-git-send-email-famz@redhat.com> <1385444708-19439-5-git-send-email-famz@redhat.com> <52ABCC09.3070000@redhat.com> <52AE9D77.20202@redhat.com> In-Reply-To: <52AE9D77.20202@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 4/6] commit: support commit active layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, kwolf@redhat.com Cc: pbonzini@redhat.com, jcody@redhat.com, stefanha@redhat.com On 2013=E5=B9=B412=E6=9C=8816=E6=97=A5 14:28, Fam Zheng wrote: > On 2013=E5=B9=B412=E6=9C=8814=E6=97=A5 11:10, Eric Blake wrote: >> On 11/25/2013 10:45 PM, Fam Zheng wrote: >>> If active is top, it will be mirrored to base, (with block/mirror.c >>> code), then the image is switched when user completes the block job. >>> >>> QMP documentation is updated. >>> >>> Signed-off-by: Fam Zheng >>> --- >> >>> +++ b/qapi-schema.json >>> @@ -1967,9 +1967,11 @@ >>> # >>> # @top: The file name of the backing image within the >>> image chain, >>> # which contains the topmost data to be >>> committed down. >>> -# Note, the active layer as 'top' is currently >>> unsupported. >>> # >>> # If top =3D=3D base, that is an error. >>> +# If top =3D=3D active, the job will not be compl= eted >>> by itself, >>> +# user needs to complete the job with the >>> block-job-complete >>> +# command after getting the ready event. (Since 1= .8) >> >> s/1.8/2.0/ > > OK, thanks. > > Kevin, if you agree with my explanation on your comment, would you fix > this while applying? > Sorry, I forgot I should rebase 05. Never mind, I'll respin. Fam