From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 1/2] gpio: davinci: don't create irq_domain in case of unbanked irqs Date: Mon, 16 Dec 2013 11:24:10 -0500 Message-ID: <52AF292A.4020106@ti.com> References: <1386871973-26762-1-git-send-email-grygorii.strashko@ti.com> <1386871973-26762-2-git-send-email-grygorii.strashko@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1386871973-26762-2-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org To: Grygorii Strashko Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Linus Walleij , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-gpio@vger.kernel.org On Thursday 12 December 2013 01:12 PM, Grygorii Strashko wrote: > The system may crash if: > - there are more then 1 bank > - unbanked irqs are enabled > - someone will call gpio_to_irq() for GPIO from bank2 or above > > Hence, fix it by not creating irq_domain if unbanked irqs are enabled > and correct gpio_to_irq_banked() to handle this properly. > > CC: Linus Walleij > CC: Sekhar Nori > CC: Santosh Shilimkar > > Signed-off-by: Grygorii Strashko > --- Acked-by: Santosh Shilimkar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754757Ab3LPQYi (ORCPT ); Mon, 16 Dec 2013 11:24:38 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:60394 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754291Ab3LPQYg (ORCPT ); Mon, 16 Dec 2013 11:24:36 -0500 Message-ID: <52AF292A.4020106@ti.com> Date: Mon, 16 Dec 2013 11:24:10 -0500 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Grygorii Strashko CC: Linus Walleij , Sekhar Nori , Rob Herring , , , , , Subject: Re: [PATCH 1/2] gpio: davinci: don't create irq_domain in case of unbanked irqs References: <1386871973-26762-1-git-send-email-grygorii.strashko@ti.com> <1386871973-26762-2-git-send-email-grygorii.strashko@ti.com> In-Reply-To: <1386871973-26762-2-git-send-email-grygorii.strashko@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 12 December 2013 01:12 PM, Grygorii Strashko wrote: > The system may crash if: > - there are more then 1 bank > - unbanked irqs are enabled > - someone will call gpio_to_irq() for GPIO from bank2 or above > > Hence, fix it by not creating irq_domain if unbanked irqs are enabled > and correct gpio_to_irq_banked() to handle this properly. > > CC: Linus Walleij > CC: Sekhar Nori > CC: Santosh Shilimkar > > Signed-off-by: Grygorii Strashko > --- Acked-by: Santosh Shilimkar From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Mon, 16 Dec 2013 11:24:10 -0500 Subject: [PATCH 1/2] gpio: davinci: don't create irq_domain in case of unbanked irqs In-Reply-To: <1386871973-26762-2-git-send-email-grygorii.strashko@ti.com> References: <1386871973-26762-1-git-send-email-grygorii.strashko@ti.com> <1386871973-26762-2-git-send-email-grygorii.strashko@ti.com> Message-ID: <52AF292A.4020106@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 12 December 2013 01:12 PM, Grygorii Strashko wrote: > The system may crash if: > - there are more then 1 bank > - unbanked irqs are enabled > - someone will call gpio_to_irq() for GPIO from bank2 or above > > Hence, fix it by not creating irq_domain if unbanked irqs are enabled > and correct gpio_to_irq_banked() to handle this properly. > > CC: Linus Walleij > CC: Sekhar Nori > CC: Santosh Shilimkar > > Signed-off-by: Grygorii Strashko > --- Acked-by: Santosh Shilimkar