From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsbNz-0000oZ-KI for qemu-devel@nongnu.org; Mon, 16 Dec 2013 11:51:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsbNu-0007Ac-O5 for qemu-devel@nongnu.org; Mon, 16 Dec 2013 11:51:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsbNu-0007AJ-Eg for qemu-devel@nongnu.org; Mon, 16 Dec 2013 11:51:10 -0500 Message-ID: <52AF2F7C.3010506@redhat.com> Date: Mon, 16 Dec 2013 09:51:08 -0700 From: Eric Blake MIME-Version: 1.0 References: <1373927181-24247-1-git-send-email-imammedo@redhat.com> <1373927181-24247-7-git-send-email-imammedo@redhat.com> In-Reply-To: <1373927181-24247-7-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="170Bcdg9CcQJoDLOBFlALRvgCrOj33UpP" Subject: Re: [Qemu-devel] [PATCH 06/20] target-i386: cleanup 'foo' feature handling' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: Paolo Bonzini , Anthony Liguori , Eduardo Habkost , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Vadim Rozenfeld This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --170Bcdg9CcQJoDLOBFlALRvgCrOj33UpP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/15/2013 04:25 PM, Igor Mammedov wrote: > features check, enforce, hv_relaxed and hv_vapic are treated as boolean= set to 'on' > when passed from command line, so it's not neccessary to handle each of= them s/neccessary/necessary/ > separetly. Collapse them to one catch-all branch which will treat s/separetly/separately/ > any feature in format 'foo' as boolean set to 'on'. >=20 > PS: > Any unknown feature will be rejected by CPU property setter so there is= no > need to check for unknown feature in cpu_x86_parse_featurestr(), theref= ore > it's replaced by above mentioned catch-all handler. >=20 > Signed-off-by: Igor Mammedov > Reviewed-by: Eduardo Habkost > --- --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --170Bcdg9CcQJoDLOBFlALRvgCrOj33UpP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSry98AAoJEKeha0olJ0NqPfkH/04T/IP3U5WErfTuNj5JPORw 6h+XQNKoiE0rByVwGOjW0D7i+KB0vP0veJUt725cEgnQtL8f+qXEvav3e3nWh0ts IpP2+fw2ex0FBdhJ6XRyrWaZKlGfzUOtaBFTcpXKgssJURKAVAZHyzFKQoKOYziC FK0s0yNX7dB7WUDSHdOCYGikLZeuSPQC9ZhL1nP6IYXVJPQISnwsbN6q2J19DT2o ZOOh23NrdUfRigpWIeogvN0xFKcVbYYGt1ZZJRjNPakFq9jmhzQLUA4LSj0sqgou nJJBQ29pj+CjxQcgk9PEiiXuzaJ/xerD6zXsPHlBf+f1ZlVz6pc04QYgDIaKs1U= =lqXw -----END PGP SIGNATURE----- --170Bcdg9CcQJoDLOBFlALRvgCrOj33UpP--