From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Bader <stefan.bader@canonical.com>
Subject: Setting devid for emulated NICs (Xen 4.3.1 / libvirt
 1.2.0) using libxl driver
Date: Tue, 17 Dec 2013 17:34:17 +0100
Message-ID: <52B07D09.5060008@canonical.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1164443785345479439=="
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: libvir-list@redhat.com, Xen-devel@lists.xen.org
Cc: Jim Fehlig <jfehlig@suse.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============1164443785345479439==
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="91xWepEd2WkohpuWev7Mu6fFbvT1O3oD8"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--91xWepEd2WkohpuWev7Mu6fFbvT1O3oD8
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable


Using virt-manager "hypervisor default" type:

    <interface type=3D'bridge'>
      <mac address=3D'00:16:3e:5e:09:9d'/>
      <source bridge=3D'br0'/>
      <script path=3D'vif-bridge'/>
    </interface>

This causes the qemu call to have "-net none" which removes PXE boot
abilities. A linux kernel has network through the xen pv-driver.

Changing in virt-manager to "e1000" type:

    <interface type=3D'bridge'>
      <mac address=3D'00:16:3e:5e:09:9d'/>
      <source bridge=3D'br0'/>
      <script path=3D'vif-bridge'/>
      <model type=3D'e1000'/>
    </interface>

This currently (Xen 4.3.1 + libvirt 1.2.0) fails and the qemu arguments
in the log look suspicious:
  -device e1000,id=3Dnic-1,netdev=3Dnet-1,mac=3D00:16:3e:5e:09:9d
  -netdev type=3Dtap,id=3Dnet-1,ifname=3Dvif1.-1-emu,script=3Dno,downscri=
pt=3Dno

Looking through git I found ba64b97134a6129a48684f22f31be92c3b6eef96
  libxl: Allow libxl to set NIC devid

which removes a line that sets the devid of new NICs. I assume the commen=
t
says (sorry I always seem to get confused reading it) that devid should
be auto-set by the libxl library provided by Xen. But I could not find
where that would be done. Even the xl command implementation sets it
explicitly. libxl_device_nic_init sets it to -1 which would explain the
wrong qemu arguments above.
For testing I re-added the following after the libxlMakeNic call:

--- libvirt-1.2.0.orig/src/libxl/libxl_conf.c   2013-12-11 17:04:17.00000=
0000 +0
+++ libvirt-1.2.0/src/libxl/libxl_conf.c        2013-12-16 19:08:46.83001=
6646 +0
@@ -907,6 +907,8 @@ libxlMakeNicList(virDomainDefPtr def,  l
     for (i =3D 0; i < nnics; i++) {
         if (libxlMakeNic(l_nics[i], &x_nics[i]))
             goto error;
+       if (x_nics[i].devid < 0)
+               x_nics[i].devid =3D i;
     }

     d_config->nics =3D x_nics;

And with that I get a working PXE boot when I set the device type
in the config. (Side note that I think not using a type defaults to
rtl8139 in the old xend driver. Maybe this should be the same for the
xl driver).
I am not sure how the right fix for it should look like as I am unsure
which part was supposed to set the devid. Just right now it does not
seem to be done.

-Stefan


--91xWepEd2WkohpuWev7Mu6fFbvT1O3oD8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCgAGBQJSsH0TAAoJEOhnXe7L7s6jM2IQANeIyRjagN0qNiXsSd2jO2rk
dk+Hau5dMyG3KtL39xdfYokqwroSpnnbrHywa39F3+HL8J0nCKDilrPRRX+75yI4
yqBrsmxnTIjfmhMZ7L2pBcSE5bL1j9Wy4EEwkwL9qP9GUbPg4yVL2BLp0GFSQ/dZ
eNfNGEokZ5TP2u0Invd7xa1CTmmssUA8NfykAbKU/G0Esw6jOq80/s4/PiswRrW1
hYfv67csfUKiRi6jj07/h8K8DyiBWlyaDt9WBYxyBtTOG2iV+73maAIVdKTxaBnz
U4coTloV2DeNhANlzCeBNgDtX9VTN4XCC2F4btvlkqs0fd2IHLHoCewlLYJmZ/pR
wR/hSbvWNp3BGbPxKcS3A/jf5p4wy6Jo4gwzKQba15xlRbtcQwEDB9YD4hSTzje1
GyXC/d6PQQql2Oku7rmtP4JU3OgNzDUFSNHL0bbC+r9NIzQ6aQxZmjRcOIYMQl9d
pKQrNqYcj5QM0Zjfm/HjiWMtNloqMAGC5uyJNO2cxfMjKv5Rtgu8SmRHvSIpSXXM
y6smk6zMWFEMRd3CmrYnhKZNZPcZb6aWmzSsKcv+dh8x3XOpke5B6aWlUi/KkzjB
AOCnsOTKBanSLBMvSnqzyQWF61bC5BsXYJ1DIJQjL7HaVz9u0ChhtzpdLr4dMQu4
BHruLH+JiFjfB6DtV6F9
=If55
-----END PGP SIGNATURE-----

--91xWepEd2WkohpuWev7Mu6fFbvT1O3oD8--


--===============1164443785345479439==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============1164443785345479439==--