From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Bader <stefan.bader@canonical.com>
Subject: Re: Setting devid for emulated NICs (Xen 4.3.1 /
 libvirt 1.2.0) using libxl driver
Date: Tue, 17 Dec 2013 18:32:25 +0100
Message-ID: <52B08AA9.8010809__39254.6354364187$1387301697$gmane$org@canonical.com>
References: <52B07D09.5060008@canonical.com>
	<1387299534.1025.19.camel@dagon.hellion.org.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4727856244290328780=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1387299534.1025.19.camel@dagon.hellion.org.uk>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: libvir-list@redhat.com, Jim Fehlig <jfehlig@suse.com>, Xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============4727856244290328780==
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="k3uwrCirX6Gi9B8r3lInSeSWNojw4n2vE"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--k3uwrCirX6Gi9B8r3lInSeSWNojw4n2vE
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 17.12.2013 17:58, Ian Campbell wrote:
> On Tue, 2013-12-17 at 17:34 +0100, Stefan Bader wrote:
>> Using virt-manager "hypervisor default" type:
>>
>>     <interface type=3D'bridge'>
>>       <mac address=3D'00:16:3e:5e:09:9d'/>
>>       <source bridge=3D'br0'/>
>>       <script path=3D'vif-bridge'/>
>>     </interface>
>>
>> This causes the qemu call to have "-net none" which removes PXE boot
>> abilities. A linux kernel has network through the xen pv-driver.
>>
>> Changing in virt-manager to "e1000" type:
>>
>>     <interface type=3D'bridge'>
>>       <mac address=3D'00:16:3e:5e:09:9d'/>
>>       <source bridge=3D'br0'/>
>>       <script path=3D'vif-bridge'/>
>>       <model type=3D'e1000'/>
>>     </interface>
>>
>> This currently (Xen 4.3.1 + libvirt 1.2.0) fails and the qemu argument=
s
>> in the log look suspicious:
>>   -device e1000,id=3Dnic-1,netdev=3Dnet-1,mac=3D00:16:3e:5e:09:9d
>>   -netdev type=3Dtap,id=3Dnet-1,ifname=3Dvif1.-1-emu,script=3Dno,downs=
cript=3Dno
>>
>> Looking through git I found ba64b97134a6129a48684f22f31be92c3b6eef96
>>   libxl: Allow libxl to set NIC devid
>=20
> Is that a libvirt commit? Not seeing it in xen.git.

Oh, sorry, yes it is.
>=20
> Might this libxl fix be relevant:
>         commit 5420f26507fc5c9853eb1076401a8658d72669da
>         Author: Jim Fehlig <jfehlig@suse.com>
>         Date:   Fri Jan 11 12:22:26 2013 +0000
>        =20
>             libxl: Set vfb and vkb devid if not done so by the caller
>            =20
>             Other devices set a sensible devid if the caller has not do=
ne so.
>             Do the same for vfb and vkb.  While at it, factor out the c=
ommon code
>             used to determine a sensible devid, so it can be used by ot=
her
>             libxl__device_*_add functions.
>            =20
>             Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>             Acked-by: Ian Campbell <ian.campbell@citrix.com>
>             Committed-by: Ian Campbell <ian.campbell@citrix.com>
>        =20
> and a follow up in dfeccbeaa. Although the comment implies that nic's
> were already correctly assigning a devid if the caller specified -1, so=

> I don't know why it doesn't work for you :-(

Ok, yes, the commit above indeed changes libxl__device_nic_add to call
libxl__device_nextid for the devid... Just how is this actually called.
Maybe not sufficient but "git grep libxl__device_nic_add" in the xen code=
 only
shows the definition and a declaration in libxl_internal.h to me...


>=20
>>
>> which removes a line that sets the devid of new NICs. I assume the com=
ment
>> says (sorry I always seem to get confused reading it) that devid shoul=
d
>> be auto-set by the libxl library provided by Xen.
>=20
> Correct.
>=20
>> But I could not find where that would be done.
>=20
> I expect the above commits have pointed you to the right line, but the
> code should be quite near the top of libxl__device_nic_add in libxl.c
>=20
>>  Even the xl command implementation sets it
>> explicitly.
>=20
> The caller is also allowed to do this if it cares what number is used.
>=20
>>  libxl_device_nic_init sets it to -1 which would explain the
>> wrong qemu arguments above.
>=20
> Right, libxl_device_nic_init sets everything to "the defaults please"
> and __device_nic_add will instantiate any defaults which the applicatio=
n
> didn't supply.
>=20
>> For testing I re-added the following after the libxlMakeNic call:
>>
>> --- libvirt-1.2.0.orig/src/libxl/libxl_conf.c   2013-12-11 17:04:17.00=
0000000 +0
>> +++ libvirt-1.2.0/src/libxl/libxl_conf.c        2013-12-16 19:08:46.83=
0016646 +0
>> @@ -907,6 +907,8 @@ libxlMakeNicList(virDomainDefPtr def,  l
>>      for (i =3D 0; i < nnics; i++) {
>>          if (libxlMakeNic(l_nics[i], &x_nics[i]))
>>              goto error;
>> +       if (x_nics[i].devid < 0)
>> +               x_nics[i].devid =3D i;
>>      }
>>
>>      d_config->nics =3D x_nics;
>>
>> And with that I get a working PXE boot when I set the device type
>> in the config. (Side note that I think not using a type defaults to
>> rtl8139 in the old xend driver. Maybe this should be the same for the
>> xl driver).
>> I am not sure how the right fix for it should look like as I am unsure=

>> which part was supposed to set the devid. Just right now it does not
>> seem to be done.
>>
>> -Stefan
>>
>=20
>=20
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>=20



--k3uwrCirX6Gi9B8r3lInSeSWNojw4n2vE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCgAGBQJSsIqpAAoJEOhnXe7L7s6j9n4P/0ADXWuEqAI7DIfKC85Nccyf
8PV+b4LnN/FurF8Z/OJkjijvl3/8lnu4+IFi/MHWvbSicSt1hp+ePpalL5Dlpgz8
HgYXVmMF+c/Hc6cTIVgGcHNCF9DwFcGxJLqUGaflKDRZzxf6dF0lj5i7HAQZViEW
mCgYem2X6Gl++/BLpTiEhQC47A7+q8gjp+19WG6UbT8XKHZ1LzJulAhlq185YtBI
zWh3abIu5BO7nUKubmTUmFiHwZ1J/8HWt3QIcosZm02+UBGRRUzXFjbB6Isi5IL9
fW2yNp7l7Two91rStoxFhnJdZ7kmN8s/KJq4cdsj0dCXFPB1FiIhDBp/9rViRaYE
YtrYGpWG6P+taan+OG+HIn9vNjfpxWYVRQAG32i286f5gWZegN/cXh86i6hoZU5B
KNVS9P+YVeuMPuaZw5UjOyRf8Ymm8p2aGJ8LUuSt7hk7ED1NX8NfWYa/Th4v4dlU
Z94SdT1VXnbPTNiZqDOYaSlaL6yp8awt1j68mHhVwL7AnmvAa1IBE5Rp8d0qo2MQ
xxrNcHl5SVSLC9avE6OwkSQdG6kHcRx+ES/VyStSl6iwGzbdwtxyWOV9ZLWpwAPl
XReMV6Yr3kEkYqUPDYWn7kbeyB49sRytMWbgKJvTJvgPNlhT/LrON7mraG/f9Cpw
/qQLPVN72MAfeSJV9Aox
=Eb8e
-----END PGP SIGNATURE-----

--k3uwrCirX6Gi9B8r3lInSeSWNojw4n2vE--


--===============4727856244290328780==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4727856244290328780==--