From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vandana Kannan <vandana.kannan@intel.com>
Subject: Re: [PATCH 4/5]  drm/i915: Idleness detection for DRRS
Date: Wed, 18 Dec 2013 13:48:12 +0530
Message-ID: <52B15A44.9030104@intel.com>
References: <1387258107-19232-1-git-send-email-vandana.kannan@intel.com>
	<1387258107-19232-5-git-send-email-vandana.kannan@intel.com>
	<20131217122928.GI22448@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id B453311DB53
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 18 Dec 2013 00:18:15 -0800 (PST)
In-Reply-To: <20131217122928.GI22448@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Dec-17-2013 5:59 PM, Chris Wilson wrote:
> On Tue, Dec 17, 2013 at 10:58:26AM +0530, Vandana Kannan wrote:
>> Adding support to detect display idleness by tracking page flip from
>> user space. Switch to low refresh rate is triggered after 2 seconds of
>> idleness. The delay is configurable. If there is a page flip or call to
>> update the plane, then high refresh rate is applied.
>> The feature is not used in dual-display mode.
> 
> Looks very inconsistent next to intel_fbc_disable/intel_fbc_update.
> -Chris
> 
We have implemented this in a way that it is similar to fbc
implementation. Could you explain some more about your review comment?