From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vandana Kannan Subject: Re: [PATCH 2/5] drm/i915: Parse EDID probed modes for DRRS support Date: Mon, 23 Dec 2013 10:55:41 +0530 Message-ID: <52B7C955.7030105@intel.com> References: <1387534258-5283-1-git-send-email-vandana.kannan@intel.com> <1387534258-5283-3-git-send-email-vandana.kannan@intel.com> <87d2krk8od.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 6040DFC399 for ; Sun, 22 Dec 2013 21:25:43 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Dec-20-2013 7:35 PM, Daniel Vetter wrote: > On Fri, Dec 20, 2013 at 1:29 PM, Jani Nikula > wrote: >>> Signed-off-by: Pradeep Bhat >>> Signed-off-by: Vandana Kannan >>> Reviewed-by: Daniel Vetter >>> Reviewed-by: Chris Wilson >>> Reviewed-by: Jani Nikula >> >> I'm sorry, this is not true. Only I get to say when you can add my >> Reviewed-by. > > Yeah, you can't just add review-by comments. In the linux kernel this > has a very specific meaning and can't just get handed out for "has > looked at the patches". For details of what a reviewed-by tag means > please see the "Reviewer's statement of oversight" in > Documentation/SubmittingPatches. I've noticed that you've also done > this with Ville's r-b tag for the picture ratio patch, I'll send out a > note that this r-b isn't legit. > -Daniel > Thanks for your inputs. I will remove the r-b tag from all DRRS related patches, keeping the details of versions/review comments incorporated in the commit message. Also, I will follow the same and resend the patch on picture aspect ratio. - Vandana