From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751994AbaABRuQ (ORCPT ); Thu, 2 Jan 2014 12:50:16 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:3628 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbaABRuO (ORCPT ); Thu, 2 Jan 2014 12:50:14 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 02 Jan 2014 09:51:06 -0800 Message-ID: <52C5A6CE.5060904@nvidia.com> Date: Thu, 2 Jan 2014 09:50:06 -0800 From: Matthew Longnecker User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 Newsgroups: gmane.linux.power-management.general,gmane.linux.drivers.devicetree,gmane.linux.drivers.sensors,gmane.linux.kernel To: Wei Ni , Eduardo Valentin , , , , , , , CC: , , , , , Subject: Re: [PATCHv9 02/20] thermal: introduce device tree parser References: <1384285582-16933-1-git-send-email-eduardo.valentin@ti.com> <1384285582-16933-3-git-send-email-eduardo.valentin@ti.com> <52C4D612.2090808@nvidia.com> In-Reply-To: <52C4D612.2090808@nvidia.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I think the platform driver may set governor for the thermal zone, > so how about to add a property named as "governor", > and parse it to tzp->governor_name, > something like: > ret = of_property_read_string(child, "governor", &str); > if (ret == 0) > if (strlen(str) < THERMAL_NAME_LENGTH) > strcpy(tzp->governor_name, str); > > Thanks. > Wei. DT is supposed to describe the hardware, right? The governor isn't hardware -- it's a software control policy. On the other hand, that control policy must be tuned according to the behaviors of the platform hardware otherwise the system will be unstable. Is it appropriate to be naming the governor in DT? If so, is it equally appropriate to describe any governor-specific parameters in DT (even though they are pure software constructs)? -Matt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Longnecker Subject: Re: [PATCHv9 02/20] thermal: introduce device tree parser Date: Thu, 2 Jan 2014 09:50:06 -0800 Message-ID: <52C5A6CE.5060904@nvidia.com> References: <1384285582-16933-1-git-send-email-eduardo.valentin@ti.com> <1384285582-16933-3-git-send-email-eduardo.valentin@ti.com> <52C4D612.2090808@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52C4D612.2090808@nvidia.com> Sender: linux-pm-owner@vger.kernel.org To: Wei Ni , Eduardo Valentin , swarren@wwwdotorg.org, pawel.moll@arm.com, mark.rutland@arm.com, ian.campbell@citrix.com, rob.herring@calxeda.com, linux@roeck-us.net, rui.zhang@intel.com Cc: grant.likely@linaro.org, durgadoss.r@intel.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org > I think the platform driver may set governor for the thermal zone, > so how about to add a property named as "governor", > and parse it to tzp->governor_name, > something like: > ret = of_property_read_string(child, "governor", &str); > if (ret == 0) > if (strlen(str) < THERMAL_NAME_LENGTH) > strcpy(tzp->governor_name, str); > > Thanks. > Wei. DT is supposed to describe the hardware, right? The governor isn't hardware -- it's a software control policy. On the other hand, that control policy must be tuned according to the behaviors of the platform hardware otherwise the system will be unstable. Is it appropriate to be naming the governor in DT? If so, is it equally appropriate to describe any governor-specific parameters in DT (even though they are pure software constructs)? -Matt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Longnecker Date: Thu, 02 Jan 2014 17:50:06 +0000 Subject: Re: [lm-sensors] [PATCHv9 02/20] thermal: introduce device tree parser Message-Id: <52C5A6CE.5060904@nvidia.com> List-Id: References: <1384285582-16933-1-git-send-email-eduardo.valentin@ti.com> <1384285582-16933-3-git-send-email-eduardo.valentin@ti.com> <52C4D612.2090808@nvidia.com> In-Reply-To: <52C4D612.2090808@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Ni , Eduardo Valentin , swarren@wwwdotorg.org, pawel.moll@arm.com, mark.rutland@arm.com, ian.campbell@citrix.com, rob.herring@calxeda.com, linux@roeck-us.net, rui.zhang@intel.com Cc: grant.likely@linaro.org, durgadoss.r@intel.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org > I think the platform driver may set governor for the thermal zone, > so how about to add a property named as "governor", > and parse it to tzp->governor_name, > something like: > ret = of_property_read_string(child, "governor", &str); > if (ret = 0) > if (strlen(str) < THERMAL_NAME_LENGTH) > strcpy(tzp->governor_name, str); > > Thanks. > Wei. DT is supposed to describe the hardware, right? The governor isn't hardware -- it's a software control policy. On the other hand, that control policy must be tuned according to the behaviors of the platform hardware otherwise the system will be unstable. Is it appropriate to be naming the governor in DT? If so, is it equally appropriate to describe any governor-specific parameters in DT (even though they are pure software constructs)? -Matt _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors