From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH 2/4] dbg_rw_guest_mem: Enable debug log output Date: Sat, 04 Jan 2014 16:24:44 -0500 Message-ID: <52C87C1C.5080908@terremark.com> References: <1388857936-664-1-git-send-email-dslutz@verizon.com> <1388857936-664-3-git-send-email-dslutz@verizon.com> <20140104211319.GC9395@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4070028943122963288==" Return-path: In-Reply-To: <20140104211319.GC9395@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Keir Fraser , Ian Campbell , Stefano Stabellini , George Dunlap , Ian Jackson , Don Slutz , xen-devel@lists.xen.org, Jan Beulich List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============4070028943122963288== Content-Type: multipart/alternative; boundary="------------040904070703080307050903" This is a multi-part message in MIME format. --------------040904070703080307050903 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 01/04/14 16:13, Konrad Rzeszutek Wilk wrote: > On Sat, Jan 04, 2014 at 12:52:14PM -0500, Don Slutz wrote: >> This also fixes the old debug output to compile and work if DBGP1 >> and DBGP2 are defined like DBGP3. >> >> @@ -226,3 +239,11 @@ dbg_rw_mem(dbgva_t addr, dbgbyte_t *buf, int len, domid_t domid, int toaddr, >> return len; >> } >> >> +/* >> + * Local variables: >> + * mode: C >> + * c-file-style: "BSD" >> + * c-basic-offset: 4 >> + * indent-tabs-mode: nil >> + * End: >> + */ > ?? I take that as "Why add this"? Dealing with many different styles of code, I find it helps to have this emacs add. From CODING_STYLE: Emacs local variables --------------------- A comment block containing local variables for emacs is permitted at the end of files. It should be: /* * Local variables: * mode: C * c-file-style: "BSD" * c-basic-offset: 4 * indent-tabs-mode: nil * End: */ -Don Slutz --------------040904070703080307050903 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit

On 01/04/14 16:13, Konrad Rzeszutek Wilk wrote:

On Sat, Jan 04, 2014 at 12:52:14PM -0500, Don Slutz wrote:

This also fixes the old debug output to compile and work if DBGP1
and DBGP2 are defined like DBGP3.

@@ -226,3 +239,11 @@ dbg_rw_mem(dbgva_t addr, dbgbyte_t *buf, int len, domid_t domid, int toaddr,
     return len;
 }
 
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */

??

I take that as "Why add this"?

Dealing with many different styles of code, I find it helps to have this emacs add. From CODING_STYLE:

Emacs local variables
---------------------

A comment block containing local variables for emacs is permitted at
the end of files. It should be:

/*
* Local variables:
* mode: C
* c-file-style: "BSD"
* c-basic-offset: 4
* indent-tabs-mode: nil
* End:
*/

-Don Slutz
--------------040904070703080307050903-- --===============4070028943122963288== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4070028943122963288==--