From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: [libvirt] Setting devid for emulated NICs (Xen
 4.3.1 / libvirt 1.2.0) using libxl driver
Date: Mon, 06 Jan 2014 14:31:49 -0700
Message-ID: <52CB20C5.6070906@suse.com>
References: <52B07D09.5060008@canonical.com>	<1387299534.1025.19.camel@dagon.hellion.org.uk>	<52B08AA9.8010809@canonical.com>	<1387369646.27441.129.camel@kazak.uk.xensource.com>	<52B19F4E.8010601@canonical.com>	<1387373284.28680.18.camel@kazak.uk.xensource.com>	<52B1B842.4090306@canonical.com>
	<52B2415A.3030903@suse.com>	<1387448340.9925.30.camel@kazak.uk.xensource.com>	<52B3278D.3000607@canonical.com>
	<52B33D6C.6010608@suse.com>	<1387534262.17289.34.camel@kazak.uk.xensource.com>	<52B41BED.5000808@canonical.com>	<1387535806.17289.50.camel@kazak.uk.xensource.com>	<52B42459.3080609@canonical.com>
	<1387538524.17289.64.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1387538524.17289.64.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefan Bader <stefan.bader@canonical.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Ian Campbell wrote:
> On Fri, 2013-12-20 at 12:04 +0100, Stefan Bader wrote:
>   
>> config specifies no model or model == netfront:
>>  - nic->model unset, nic->type = NIC_TYPE_VIF
>> config specifies any other mode:
>>  - nic->model = <name>, nic-type = NIC_TYPE_VIF_IOEMU
>>
>> In libxl__device_nic_setdefault:
>>  - nic->model unset -> nic->model = "rtl8139"
>>  - For HWM domain
>>    - nic->type unset -> nic-type = NIC_TYPE_VIF_IOEMU
>>     
>
> OK, I think this is all working as intended.
>
>   
>> I am only "complaining" about the case of having no NIC model set in the libvirt
>> configuration. This sets NIC_TYPE_VIF but leaves nic->model unset.
>> libxl sets the nic->model later but that has no effect because the type is set
>> to VIF only.
>>     
>
> Correct, the setting of nic->model here is irrelevant since that field
> is ignored if the type is not VIF+IOEMU.
>
>   
>>  And the default used to be VIF+IOEMU with rtl8139 as model.
>>     
>
> Right, this sounds like a libvirt level issue then.
>   

The following patch work in my testing

https://www.redhat.com/archives/libvir-list/2014-January/msg00208.html

Stefan, can you help test/review the patch?  Would be nice to get this
pushed for the upcoming libvirt 1.2.1 release.

Regards,
Jim