All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] thermal: rcar: Add missing clock handling
Date: Wed, 08 Jan 2014 12:20:00 +0000	[thread overview]
Message-ID: <52CD4270.3010907@codethink.co.uk> (raw)
In-Reply-To: <20140107205719.GL20094@book.gsilab.sittig.org>

On 07/01/14 20:57, Gerhard Sittig wrote:
> On Tue, Jan 07, 2014 at 19:57 +0100, Geert Uytterhoeven wrote:
>>
>> @@ -378,23 +380,38 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>>   	spin_lock_init(&common->lock);
>>   	common->dev = dev;
>>
>> +	common->clk = devm_clk_get(&pdev->dev, NULL);
>> +	if (IS_ERR(common->clk)) {
>> +		dev_err(&pdev->dev, "cannot get clock\n");
>> +		return PTR_ERR(common->clk);
>> +	}
>> +
>> +	ret = clk_prepare(common->clk);
>> +	if (ret < 0) {
>> +		dev_err(&pdev->dev, "unable to prepare clock\n");
>> +		return ret;
>> +	}
>> +
>> +	clk_enable(common->clk);
>> +
>>   	pm_runtime_enable(dev);
>>   	pm_runtime_get_sync(dev);
>
> clk_enable() can fail, too, so you should check its return value

Also, if you enable the pm-runtime then the device clock is actually
handled by the common pm-clock framework.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Gerhard Sittig <gsi@denx.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <eduardo.valentin@ti.com>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/4] thermal: rcar: Add missing clock handling
Date: Wed, 08 Jan 2014 12:20:00 +0000	[thread overview]
Message-ID: <52CD4270.3010907@codethink.co.uk> (raw)
In-Reply-To: <20140107205719.GL20094@book.gsilab.sittig.org>

On 07/01/14 20:57, Gerhard Sittig wrote:
> On Tue, Jan 07, 2014 at 19:57 +0100, Geert Uytterhoeven wrote:
>>
>> @@ -378,23 +380,38 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>>   	spin_lock_init(&common->lock);
>>   	common->dev = dev;
>>
>> +	common->clk = devm_clk_get(&pdev->dev, NULL);
>> +	if (IS_ERR(common->clk)) {
>> +		dev_err(&pdev->dev, "cannot get clock\n");
>> +		return PTR_ERR(common->clk);
>> +	}
>> +
>> +	ret = clk_prepare(common->clk);
>> +	if (ret < 0) {
>> +		dev_err(&pdev->dev, "unable to prepare clock\n");
>> +		return ret;
>> +	}
>> +
>> +	clk_enable(common->clk);
>> +
>>   	pm_runtime_enable(dev);
>>   	pm_runtime_get_sync(dev);
>
> clk_enable() can fail, too, so you should check its return value

Also, if you enable the pm-runtime then the device clock is actually
handled by the common pm-clock framework.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

WARNING: multiple messages have this Message-ID (diff)
From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] thermal: rcar: Add missing clock handling
Date: Wed, 08 Jan 2014 12:20:00 +0000	[thread overview]
Message-ID: <52CD4270.3010907@codethink.co.uk> (raw)
In-Reply-To: <20140107205719.GL20094@book.gsilab.sittig.org>

On 07/01/14 20:57, Gerhard Sittig wrote:
> On Tue, Jan 07, 2014 at 19:57 +0100, Geert Uytterhoeven wrote:
>>
>> @@ -378,23 +380,38 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>>   	spin_lock_init(&common->lock);
>>   	common->dev = dev;
>>
>> +	common->clk = devm_clk_get(&pdev->dev, NULL);
>> +	if (IS_ERR(common->clk)) {
>> +		dev_err(&pdev->dev, "cannot get clock\n");
>> +		return PTR_ERR(common->clk);
>> +	}
>> +
>> +	ret = clk_prepare(common->clk);
>> +	if (ret < 0) {
>> +		dev_err(&pdev->dev, "unable to prepare clock\n");
>> +		return ret;
>> +	}
>> +
>> +	clk_enable(common->clk);
>> +
>>   	pm_runtime_enable(dev);
>>   	pm_runtime_get_sync(dev);
>
> clk_enable() can fail, too, so you should check its return value

Also, if you enable the pm-runtime then the device clock is actually
handled by the common pm-clock framework.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

  reply	other threads:[~2014-01-08 12:20 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 18:57 [PATCH 0/4] thermal: rcar: Add missing clock handling Geert Uytterhoeven
2014-01-07 18:57 ` Geert Uytterhoeven
2014-01-07 18:57 ` Geert Uytterhoeven
2014-01-07 18:57 ` [PATCH 1/4] ARM: shmobile: r8a7791: Add thermal clock in device tree Geert Uytterhoeven
2014-01-07 18:57   ` Geert Uytterhoeven
2014-01-07 18:57   ` Geert Uytterhoeven
2014-01-08  0:20   ` Laurent Pinchart
2014-01-08  0:20     ` Laurent Pinchart
2014-01-08  0:20     ` Laurent Pinchart
2014-01-08  0:52     ` Simon Horman
2014-01-08  0:52       ` Simon Horman
2014-01-08  0:52       ` Simon Horman
2014-02-23 12:40   ` [PATCH 1/4] ARM: shmobile: r8a7791: add IIC0/1 clock macros Wolfram Sang
2014-02-23 22:13   ` Laurent Pinchart
2014-02-24 10:33   ` Wolfram Sang
2014-01-07 18:57 ` [PATCH 2/4] ARM: shmobile: r8a7790: Add thermal clock in device tree Geert Uytterhoeven
2014-01-07 18:57   ` Geert Uytterhoeven
2014-01-07 18:57   ` Geert Uytterhoeven
2014-01-08  0:20   ` Laurent Pinchart
2014-01-08  0:20     ` Laurent Pinchart
2014-01-08  0:20     ` Laurent Pinchart
2014-01-08  0:52     ` Simon Horman
2014-01-08  0:52       ` Simon Horman
2014-01-08  0:52       ` Simon Horman
2014-01-14  2:25   ` [PATCH 2/4] ARM: shmobile: r8a7790: add audio clock Kuninori Morimoto
2014-01-07 18:57 ` [PATCH 3/4] thermal: rcar: Add missing clock handling Geert Uytterhoeven
2014-01-07 18:57   ` Geert Uytterhoeven
2014-01-07 18:57   ` Geert Uytterhoeven
2014-01-07 20:04   ` Sergei Shtylyov
2014-01-07 20:04     ` Sergei Shtylyov
2014-01-07 20:04     ` Sergei Shtylyov
2014-01-07 20:57   ` Gerhard Sittig
2014-01-07 20:57     ` Gerhard Sittig
2014-01-07 20:57     ` Gerhard Sittig
2014-01-08 12:20     ` Ben Dooks [this message]
2014-01-08 12:20       ` Ben Dooks
2014-01-08 12:20       ` Ben Dooks
2014-01-08  1:08   ` Kuninori Morimoto
2014-01-08  1:08     ` Kuninori Morimoto
2014-01-08  1:08     ` Kuninori Morimoto
2014-01-08 10:23     ` Geert Uytterhoeven
2014-01-08 10:23       ` Geert Uytterhoeven
2014-01-08 10:23       ` Geert Uytterhoeven
2014-01-13  8:57       ` Geert Uytterhoeven
2014-01-13  8:57         ` Geert Uytterhoeven
2014-01-13  8:57         ` Geert Uytterhoeven
2014-01-14  0:20         ` Kuninori Morimoto
2014-01-14  0:20           ` Kuninori Morimoto
2014-01-14  0:20           ` Kuninori Morimoto
2014-01-14  1:27         ` Simon Horman
2014-01-14  1:27           ` Simon Horman
2014-01-14  1:27           ` Simon Horman
2014-01-08 12:23   ` Ben Dooks
2014-01-08 12:23     ` Ben Dooks
2014-01-08 12:23     ` Ben Dooks
2014-01-08 12:58     ` Geert Uytterhoeven
2014-01-08 12:58       ` Geert Uytterhoeven
2014-01-08 12:58       ` Geert Uytterhoeven
2014-01-07 18:57 ` [PATCH -trivial 4/4] thermal: rcar: Spelling s/delaye/delay/g Geert Uytterhoeven
2014-01-07 18:57   ` Geert Uytterhoeven
2014-01-07 18:57   ` Geert Uytterhoeven
2014-01-08  0:12   ` Simon Horman
2014-01-08  0:12     ` Simon Horman
2014-01-08  0:12     ` Simon Horman
2014-01-17  8:23   ` Zhang Rui
2014-01-17  8:23     ` Zhang Rui
2014-01-17  8:23     ` Zhang Rui
2014-01-07 21:52 ` [PATCH 0/4] thermal: rcar: Add missing clock handling Valentine
2014-01-07 21:52   ` Valentine
2014-01-07 21:52   ` Valentine
2014-01-07 22:13   ` Geert Uytterhoeven
2014-01-07 22:13     ` Geert Uytterhoeven
2014-01-07 22:13     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CD4270.3010907@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.