From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W271v-0005bX-8o for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:27:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W271p-0003sw-9w for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:27:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W271p-0003rm-1a for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:27:41 -0500 Message-ID: <52D1C5BA.702@redhat.com> Date: Sat, 11 Jan 2014 23:29:14 +0100 From: Max Reitz MIME-Version: 1.0 References: <1386940979-3824-1-git-send-email-kwolf@redhat.com> <1386940979-3824-21-git-send-email-kwolf@redhat.com> In-Reply-To: <1386940979-3824-21-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 20/24] block: Align requests in bdrv_co_do_pwritev() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, pl@kamp.de, stefanha@redhat.com On 13.12.2013 14:22, Kevin Wolf wrote: > This patch changes bdrv_co_do_pwritev() to actually be what its name > promises. If requests aren't properly aligned, it performs a RMW. > > Requests touching the same block are serialised against the RMW request. > Further optimisation of this is possible by differentiating types of > requests (concurrent reads should actually be okay here). > > Signed-off-by: Kevin Wolf > --- > block.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 85 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz