From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2XUc-0004CJ-UZ for qemu-devel@nongnu.org; Sun, 12 Jan 2014 21:43:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2XUV-0000kq-2t for qemu-devel@nongnu.org; Sun, 12 Jan 2014 21:43:10 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:35941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2XUU-0000ki-AZ for qemu-devel@nongnu.org; Sun, 12 Jan 2014 21:43:02 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 13 Jan 2014 12:42:59 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 7F80C2CE8056 for ; Mon, 13 Jan 2014 13:42:56 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0D2Ntis60293158 for ; Mon, 13 Jan 2014 13:23:56 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0D2gtx6003283 for ; Mon, 13 Jan 2014 13:42:55 +1100 Message-ID: <52D352AC.5050208@linux.vnet.ibm.com> Date: Mon, 13 Jan 2014 10:42:52 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1389172118-25402-1-git-send-email-pl@kamp.de> <1389172118-25402-7-git-send-email-pl@kamp.de> <52CE5DF0.2040806@linux.vnet.ibm.com> <52CECD82.4030809@kamp.de> <52CF6478.2030207@linux.vnet.ibm.com> <52D0741D.2080702@kamp.de> In-Reply-To: <52D0741D.2080702@kamp.de> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: sw@weilnetz.de, aliguori@amazon.com 于 2014/1/11 6:28, Peter Lieven 写道: > Am 10.01.2014 04:09, schrieb Wenchao Xia: >> 于 2014/1/10 0:25, Peter Lieven 写道: >>> Am 09.01.2014 09:29, schrieb Wenchao Xia: >>>> 于 2014/1/8 17:08, Peter Lieven 写道: >>>>> Signed-off-by: Peter Lieven >>>>> --- >>>>> ui/vnc.c | 9 +++++++++ >>>>> 1 file changed, 9 insertions(+) >>>>> >>>>> diff --git a/ui/vnc.c b/ui/vnc.c >>>>> index da552fe..a742d32 100644 >>>>> --- a/ui/vnc.c >>>>> +++ b/ui/vnc.c >>>>> @@ -3170,7 +3170,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) >>>>> acl = 1; >>>>> #endif >>>>> } else if (strncmp(options, "lossy", 5) == 0) { >>>>> +#ifdef CONFIG_VNC_JPEG >>>>> vs->lossy = true; >>>>> +#endif >>>>> } else if (strncmp(options, "non-adaptive", 12) == 0) { >>>>> vs->non_adaptive = true; >>>>> } else if (strncmp(options, "share=", 6) == 0) { >>>>> @@ -3187,6 +3189,13 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) >>>>> } >>>>> } >>>>> >>>>> + /* adaptive updates are only used with tight encoding and >>>>> + * if lossy updates are enabled so we can disable all the >>>>> + * calculations otherwise */ >>>>> + if (!vs->lossy) { >>>>> + vs->non_adaptive = true; >>>>> + } >>>>> + >>>> The code seems: if vs->loosy == false, then vs->non_adaptive = true, >>>> translate as: if loosy update is not used, then don't do adaptive >>>> update., which doesn't conform with the comments. I am not sure if this >>>> is on expectation. >>> It don't see the logic break. The option means non_adaptive, not adaptive. >>> >>> I write "adaptive updates are only used ... with lossy updates...". Which >> So tight encoding means loosy updates? > It means you can only enable lossy updates if you have tight encoding. So if you are > missing tight encoding or lossy is false then you can set non_adaptive to true. > > Peter > I see the logic, guess I punctuated the comments in a wrong way, the real meaning may be: /* Adaptive updates are only used with tight encoding and * if lossy updates are enabled, so we can disable all the * calculations otherwise */