From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2cqb-0007BV-T4 for qemu-devel@nongnu.org; Mon, 13 Jan 2014 03:26:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2cqW-0001Pc-A4 for qemu-devel@nongnu.org; Mon, 13 Jan 2014 03:26:13 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:40947 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2cqV-0001PW-Vx for qemu-devel@nongnu.org; Mon, 13 Jan 2014 03:26:08 -0500 Message-ID: <52D3A380.2090805@kamp.de> Date: Mon, 13 Jan 2014 09:27:44 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1389172118-25402-1-git-send-email-pl@kamp.de> <1389172118-25402-7-git-send-email-pl@kamp.de> <52CE5DF0.2040806@linux.vnet.ibm.com> <52CECD82.4030809@kamp.de> <52CF6478.2030207@linux.vnet.ibm.com> <52D0741D.2080702@kamp.de> <52D352AC.5050208@linux.vnet.ibm.com> In-Reply-To: <52D352AC.5050208@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: sw@weilnetz.de, aliguori@amazon.com On 13.01.2014 03:42, Wenchao Xia wrote: > 于 2014/1/11 6:28, Peter Lieven 写道: >> Am 10.01.2014 04:09, schrieb Wenchao Xia: >>> 于 2014/1/10 0:25, Peter Lieven 写道: >>>> Am 09.01.2014 09:29, schrieb Wenchao Xia: >>>>> 于 2014/1/8 17:08, Peter Lieven 写道: >>>>>> Signed-off-by: Peter Lieven >>>>>> --- >>>>>> ui/vnc.c | 9 +++++++++ >>>>>> 1 file changed, 9 insertions(+) >>>>>> >>>>>> diff --git a/ui/vnc.c b/ui/vnc.c >>>>>> index da552fe..a742d32 100644 >>>>>> --- a/ui/vnc.c >>>>>> +++ b/ui/vnc.c >>>>>> @@ -3170,7 +3170,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) >>>>>> acl = 1; >>>>>> #endif >>>>>> } else if (strncmp(options, "lossy", 5) == 0) { >>>>>> +#ifdef CONFIG_VNC_JPEG >>>>>> vs->lossy = true; >>>>>> +#endif >>>>>> } else if (strncmp(options, "non-adaptive", 12) == 0) { >>>>>> vs->non_adaptive = true; >>>>>> } else if (strncmp(options, "share=", 6) == 0) { >>>>>> @@ -3187,6 +3189,13 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) >>>>>> } >>>>>> } >>>>>> >>>>>> + /* adaptive updates are only used with tight encoding and >>>>>> + * if lossy updates are enabled so we can disable all the >>>>>> + * calculations otherwise */ >>>>>> + if (!vs->lossy) { >>>>>> + vs->non_adaptive = true; >>>>>> + } >>>>>> + >>>>> The code seems: if vs->loosy == false, then vs->non_adaptive = true, >>>>> translate as: if loosy update is not used, then don't do adaptive >>>>> update., which doesn't conform with the comments. I am not sure if this >>>>> is on expectation. >>>> It don't see the logic break. The option means non_adaptive, not adaptive. >>>> >>>> I write "adaptive updates are only used ... with lossy updates...". Which >>> So tight encoding means loosy updates? >> It means you can only enable lossy updates if you have tight encoding. So if you are >> missing tight encoding or lossy is false then you can set non_adaptive to true. >> >> Peter >> > I see the logic, guess I punctuated the comments in a wrong way, the > real meaning may be: > > /* Adaptive updates are only used with tight encoding and > * if lossy updates are enabled, so we can disable all the > * calculations otherwise */ > Agreed. The comma there makes it clearer. Peter -- Mit freundlichen Grüßen Peter Lieven ........................................................... KAMP Netzwerkdienste GmbH Vestische Str. 89-91 | 46117 Oberhausen Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40 pl@kamp.de | http://www.kamp.de Geschäftsführer: Heiner Lante | Michael Lante Amtsgericht Duisburg | HRB Nr. 12154 USt-Id-Nr.: DE 120607556 ...........................................................