From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35536)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W3OPq-0003is-Ac
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 06:13:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W3OPj-0007yM-Fm
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 06:13:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48091)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W3OPj-0007yD-7Y
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 06:13:39 -0500
Message-ID: <52D66D53.7060206@redhat.com>
Date: Wed, 15 Jan 2014 12:13:23 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20140108200217.GA4094@ERROL.INI.CMU.EDU>
	<20140108203821.GE18312@redhat.com>
	<20140108210942.GB4094@ERROL.INI.CMU.EDU>
In-Reply-To: <20140108210942.GB4094@ERROL.INI.CMU.EDU>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and
	ACPI on i386
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: agraf@suse.de, imammedo@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

Il 08/01/2014 22:09, Gabriel L. Somlo ha scritto:
> On Wed, Jan 08, 2014 at 10:38:21PM +0200, Michael S. Tsirkin wrote:
>>> > > +        /* _STA will be patched to 0x0F if the FDC is present */
>>> > > +        ACPI_EXTRACT_NAME_WORD_CONST DSDT_FDC_STA
>>> > > +        Name(_STA, 0xFF00)
>> > 
>> > I'm not sure why this is WORD. Spec says bits 0-4 have meaning bits up
>> > to 31 are cleared. So should not this be either dword (to make all
>> > 32 bits explicit) or byte (to make it small)?
> You're right of course, _STA returns 32 bits, 5 of which are defined,
> and the rest are reserved and "must be cleared".
> 
> As such, I think it should be DWORD (and I'm not confident enough to
> be sure no breakage would occur if we go "BYTE" instead :) )

Byte should work.  Internally, the AML interpreter treats all integers
as either 32-bit or 64-bit depending on the version.

Paolo