From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH] unmodified_drivers: make usbfront build conditional Date: Mon, 20 Jan 2014 09:47:42 +0000 Message-ID: <52DCFECE0200007800114F1B@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartB88B3BAE.1__=" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1W5BSN-0004MQ-9D for xen-devel@lists.xenproject.org; Mon, 20 Jan 2014 09:47:47 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel Cc: Olaf Hering List-Id: xen-devel@lists.xenproject.org This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__PartB88B3BAE.1__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Commit 0dcfb88fb8 ("unmodified_drivers: enable build of usbfront driver") results in the PV drivers to no longer build against older (pre-2.6.35) Linux versions. That's because usbfront.h includes headers from drivers/usb/core/, which is generally unavailable when building out-of-tree modules. Signed-off-by: Jan Beulich --- a/unmodified_drivers/linux-2.6/usbfront/Kbuild +++ b/unmodified_drivers/linux-2.6/usbfront/Kbuild @@ -1,5 +1,7 @@ include $(M)/overrides.mk =20 -obj-m +=3D xen-usb.o +obj-m +=3D $(if $(shell grep '^\#include "\.\./\.\./' $(obj)/usbfront.h), = \ + $(warning usbfront cannot be built), \ + xen-usb.o) =20 xen-usb-objs :=3D usbfront-hcd.o xenbus.o --=__PartB88B3BAE.1__= Content-Type: text/plain; name="pvdrv-usbfront-conditional.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="pvdrv-usbfront-conditional.patch" unmodified_drivers: make usbfront build conditional=0A=0ACommit 0dcfb88fb8 = ("unmodified_drivers: enable build of usbfront=0Adriver") results in the = PV drivers to no longer build against older=0A(pre-2.6.35) Linux versions. = That's because usbfront.h includes=0Aheaders from drivers/usb/core/, which = is generally unavailable when=0Abuilding out-of-tree modules.=0A=0ASigned-o= ff-by: Jan Beulich =0A=0A--- a/unmodified_drivers/linux-= 2.6/usbfront/Kbuild=0A+++ b/unmodified_drivers/linux-2.6/usbfront/Kbuild=0A= @@ -1,5 +1,7 @@=0A include $(M)/overrides.mk=0A =0A-obj-m +=3D xen-usb.o=0A= +obj-m +=3D $(if $(shell grep '^\#include "\.\./\.\./' $(obj)/usbfront.h), = \=0A+ $(warning usbfront cannot be built), \=0A+ = xen-usb.o)=0A =0A xen-usb-objs :=3D usbfront-hcd.o xenbus.o=0A --=__PartB88B3BAE.1__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --=__PartB88B3BAE.1__=--