Re: [PATCH V3 2/2] Add missing RDEPENDS of initscripts-functions

[ChenQi <Qi.Chen@windriver.com>]

Hi Martin & Paul,

I've reworked on this issue, and patches have been sent out.
It would be really appreciated if you could have a look at the patches.

Best Regards,
Chen Qi

On 01/20/2014 06:18 PM, Martin Jansa wrote:
> On Mon, Jan 20, 2014 at 10:15:41AM +0800, ChenQi wrote:
>> On 01/17/2014 11:37 PM, Martin Jansa wrote:
>>> On Fri, Jan 17, 2014 at 02:11:39PM +0000, Paul Eggleton wrote:
>>>> Hi Qi,
>>>>
>>>> On Monday 06 January 2014 15:27:35 Chen Qi wrote:
>>>>> Now that the initscripts-functions has been packaged separately,
>>>>> packages which may use the functions script should have a runtime
>>>>> dependency on it.
>>>>>
>>>>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>>>>> ---
>>>>>    meta/recipes-bsp/alsa-state/alsa-state.bb          |    2 +-
>>>>>    meta/recipes-bsp/apmd/apmd_3.2.2-14.bb             |    1 +
>>>>>    .../irda-utils/irda-utils_0.9.18.bb                |    2 ++
>>>>>    .../nfs-utils/nfs-utils_1.2.9.bb                   |    4 ++--
>>>>>    meta/recipes-connectivity/openssh/openssh_6.4p1.bb |    2 +-
>>>>>    meta/recipes-connectivity/ppp/ppp_2.4.5.bb         |    1 +
>>>>>    meta/recipes-core/dbus/dbus.inc                    |    2 +-
>>>>>    meta/recipes-core/systemd/systemd_208.bb           |    2 +-
>>>>>    meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb     |    2 +-
>>>>>    meta/recipes-devtools/distcc/distcc_3.1.bb         |    1 +
>>>>>    meta/recipes-devtools/tcf-agent/tcf-agent_git.bb   |    2 +-
>>>>>    meta/recipes-extended/at/at_3.1.14.bb              |    3 +--
>>>>>    meta/recipes-extended/cronie/cronie_1.4.11.bb      |    2 ++
>>>>>    meta/recipes-extended/rpcbind/rpcbind_0.2.1.bb     |    2 ++
>>>>>    meta/recipes-extended/sysklogd/sysklogd.inc        |    2 ++
>>>>>    meta/recipes-extended/xinetd/xinetd_2.3.15.bb      |    1 +
>>>>>    .../oprofile/oprofileui-server_git.bb              |    2 +-
>>>>>    17 files changed, 22 insertions(+), 11 deletions(-)
>>>> Sorry to come back on this patchset again, but could we not detect
>>>> installation of an initscript requiring these functions in update-rc.d.bbclass
>>>> and just add the RDEPENDS automatically? Otherwise it's just another thing
>>>> people can get wrong when writing a recipe, not to mention all of the existing
>>>> recipes outside OE-Core that install initscripts.
>>> Agreed, my current list of components where I've reverted this (to get
>>> my images building again) is:
>>>
>>> dbus, systemd, apmd, rpcbind, nfs-utils, alsa-state, openssh, ppp,
>>> cronie, irda-utils
>> Hi Martin,
>>
>> Could you please give me some more information why to revert this?
>> I really don't want to mess things up. So I really wish I could be aware
>> of some potential problems before I start working on this.
> I'm using systemd only, so on my image there aren't sysvinit scripts
> installed and to make sure that everything stays that way I've
> blacklisted initscripts recipe in distro configuration.
>
> http://lists.openembedded.org/pipermail/openembedded-core/2014-January/088116.html
>
> So including it only when update-rc.d is enabled and the sysvinit script
> isn't masked by systemd service or disabled by
> openembedded-core/meta/recipes-core/systemd/systemd-compat-units.bb
> looks like good compromise.
>
> Changing it to RRECOMMENDS isn't really
> correct (because it's either mandatory required or not at all), but it
> would also make "disabling" it a bit easier.
>
> Regards,
>
>> Best Regards,
>> Chen Qi
>>
>>> To be fair, it's possible that some of these need it and I just don't
>>> use their script in runtime (e.g. irda-utils is included only in image
>>> on "spitz" MACHINE and I've never used irda here - it's pulled through
>>> some packagegroup because MACHINE_FEATURES have irda)
>>>