From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbaA0FMo (ORCPT ); Mon, 27 Jan 2014 00:12:44 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:60740 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbaA0FMm (ORCPT ); Mon, 27 Jan 2014 00:12:42 -0500 Message-ID: <52E5EAC1.2070306@linaro.org> Date: Mon, 27 Jan 2014 14:12:33 +0900 From: AKASHI Takahiro User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Catalin Marinas CC: "viro@zeniv.linux.org.uk" , "eparis@redhat.com" , "rgb@redhat.com" , Will Deacon , "arndb@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" , "linux-audit@redhat.com" , "patches@linaro.org" Subject: Re: [PATCH v2 1/6] audit: Enable arm64 support References: <1389946399-4525-1-git-send-email-takahiro.akashi@linaro.org> <1389946399-4525-2-git-send-email-takahiro.akashi@linaro.org> <20140123141808.GD27520@arm.com> In-Reply-To: <20140123141808.GD27520@arm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [To audit maintainers] On 01/23/2014 11:18 PM, Catalin Marinas wrote: > On Fri, Jan 17, 2014 at 08:13:14AM +0000, AKASHI Takahiro wrote: >> --- a/include/uapi/linux/audit.h >> +++ b/include/uapi/linux/audit.h >> @@ -327,6 +327,8 @@ enum { >> /* distinguish syscall tables */ >> #define __AUDIT_ARCH_64BIT 0x80000000 >> #define __AUDIT_ARCH_LE 0x40000000 >> +#define AUDIT_ARCH_AARCH64 (EM_AARCH64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) >> +#define AUDIT_ARCH_AARCH64EB (EM_AARCH64|__AUDIT_ARCH_64BIT) >> #define AUDIT_ARCH_ALPHA (EM_ALPHA|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) >> #define AUDIT_ARCH_ARM (EM_ARM|__AUDIT_ARCH_LE) >> #define AUDIT_ARCH_ARMEB (EM_ARM) >> diff --git a/init/Kconfig b/init/Kconfig >> index 79383d3..3aae602 100644 >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -284,7 +284,7 @@ config AUDIT >> >> config AUDITSYSCALL >> bool "Enable system-call auditing support" >> - depends on AUDIT && (X86 || PARISC || PPC || S390 || IA64 || UML || SPARC64 || SUPERH || (ARM && AEABI && !OABI_COMPAT)) >> + depends on AUDIT && (X86 || PARISC || PPC || S390 || IA64 || UML || SPARC64 || SUPERH || (ARM && AEABI && !OABI_COMPAT) || ARM64) > > The usual comment for such changes: could you please clean this up and > just use something like "depends on HAVE_ARCH_AUDITSYSCALL"? Do you agree to this change? If so, I can create a patch, but have some concerns: 1) I can't verify it on other architectures than (arm &) arm64. 2) Some architectures (microblaze, mips, openrisc) are not listed here, but their ptrace.c have a call to audit_syscall_entry/exit(). (audit_syscall_entry/exit are null if !AUDITSYSCALL, though) So I'm afraid that the change might break someone's assumption. Thanks, -Takahiro AKASHI From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Subject: Re: [PATCH v2 1/6] audit: Enable arm64 support Date: Mon, 27 Jan 2014 14:12:33 +0900 Message-ID: <52E5EAC1.2070306@linaro.org> References: <1389946399-4525-1-git-send-email-takahiro.akashi@linaro.org> <1389946399-4525-2-git-send-email-takahiro.akashi@linaro.org> <20140123141808.GD27520@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140123141808.GD27520@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Catalin Marinas Cc: "viro@zeniv.linux.org.uk" , "eparis@redhat.com" , "rgb@redhat.com" , Will Deacon , "arndb@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" , "linux-audit@redhat.com" , "patches@linaro.org" List-Id: linux-audit@redhat.com [To audit maintainers] On 01/23/2014 11:18 PM, Catalin Marinas wrote: > On Fri, Jan 17, 2014 at 08:13:14AM +0000, AKASHI Takahiro wrote: >> --- a/include/uapi/linux/audit.h >> +++ b/include/uapi/linux/audit.h >> @@ -327,6 +327,8 @@ enum { >> /* distinguish syscall tables */ >> #define __AUDIT_ARCH_64BIT 0x80000000 >> #define __AUDIT_ARCH_LE 0x40000000 >> +#define AUDIT_ARCH_AARCH64 (EM_AARCH64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) >> +#define AUDIT_ARCH_AARCH64EB (EM_AARCH64|__AUDIT_ARCH_64BIT) >> #define AUDIT_ARCH_ALPHA (EM_ALPHA|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) >> #define AUDIT_ARCH_ARM (EM_ARM|__AUDIT_ARCH_LE) >> #define AUDIT_ARCH_ARMEB (EM_ARM) >> diff --git a/init/Kconfig b/init/Kconfig >> index 79383d3..3aae602 100644 >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -284,7 +284,7 @@ config AUDIT >> >> config AUDITSYSCALL >> bool "Enable system-call auditing support" >> - depends on AUDIT && (X86 || PARISC || PPC || S390 || IA64 || UML || SPARC64 || SUPERH || (ARM && AEABI && !OABI_COMPAT)) >> + depends on AUDIT && (X86 || PARISC || PPC || S390 || IA64 || UML || SPARC64 || SUPERH || (ARM && AEABI && !OABI_COMPAT) || ARM64) > > The usual comment for such changes: could you please clean this up and > just use something like "depends on HAVE_ARCH_AUDITSYSCALL"? Do you agree to this change? If so, I can create a patch, but have some concerns: 1) I can't verify it on other architectures than (arm &) arm64. 2) Some architectures (microblaze, mips, openrisc) are not listed here, but their ptrace.c have a call to audit_syscall_entry/exit(). (audit_syscall_entry/exit are null if !AUDITSYSCALL, though) So I'm afraid that the change might break someone's assumption. Thanks, -Takahiro AKASHI From mboxrd@z Thu Jan 1 00:00:00 1970 From: takahiro.akashi@linaro.org (AKASHI Takahiro) Date: Mon, 27 Jan 2014 14:12:33 +0900 Subject: [PATCH v2 1/6] audit: Enable arm64 support In-Reply-To: <20140123141808.GD27520@arm.com> References: <1389946399-4525-1-git-send-email-takahiro.akashi@linaro.org> <1389946399-4525-2-git-send-email-takahiro.akashi@linaro.org> <20140123141808.GD27520@arm.com> Message-ID: <52E5EAC1.2070306@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org [To audit maintainers] On 01/23/2014 11:18 PM, Catalin Marinas wrote: > On Fri, Jan 17, 2014 at 08:13:14AM +0000, AKASHI Takahiro wrote: >> --- a/include/uapi/linux/audit.h >> +++ b/include/uapi/linux/audit.h >> @@ -327,6 +327,8 @@ enum { >> /* distinguish syscall tables */ >> #define __AUDIT_ARCH_64BIT 0x80000000 >> #define __AUDIT_ARCH_LE 0x40000000 >> +#define AUDIT_ARCH_AARCH64 (EM_AARCH64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) >> +#define AUDIT_ARCH_AARCH64EB (EM_AARCH64|__AUDIT_ARCH_64BIT) >> #define AUDIT_ARCH_ALPHA (EM_ALPHA|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) >> #define AUDIT_ARCH_ARM (EM_ARM|__AUDIT_ARCH_LE) >> #define AUDIT_ARCH_ARMEB (EM_ARM) >> diff --git a/init/Kconfig b/init/Kconfig >> index 79383d3..3aae602 100644 >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -284,7 +284,7 @@ config AUDIT >> >> config AUDITSYSCALL >> bool "Enable system-call auditing support" >> - depends on AUDIT && (X86 || PARISC || PPC || S390 || IA64 || UML || SPARC64 || SUPERH || (ARM && AEABI && !OABI_COMPAT)) >> + depends on AUDIT && (X86 || PARISC || PPC || S390 || IA64 || UML || SPARC64 || SUPERH || (ARM && AEABI && !OABI_COMPAT) || ARM64) > > The usual comment for such changes: could you please clean this up and > just use something like "depends on HAVE_ARCH_AUDITSYSCALL"? Do you agree to this change? If so, I can create a patch, but have some concerns: 1) I can't verify it on other architectures than (arm &) arm64. 2) Some architectures (microblaze, mips, openrisc) are not listed here, but their ptrace.c have a call to audit_syscall_entry/exit(). (audit_syscall_entry/exit are null if !AUDITSYSCALL, though) So I'm afraid that the change might break someone's assumption. Thanks, -Takahiro AKASHI