From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH stable 3.9+] can: add destructor for self generated skbs Date: Thu, 30 Jan 2014 10:24:08 +0100 Message-ID: <52EA1A38.1000904@pengutronix.de> References: <52EA1740.2010108@hartkopp.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WA6A5mqktXmbQBJ6IkS0PDHfQt7VhEOHV" Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:41924 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbaA3JYT (ORCPT ); Thu, 30 Jan 2014 04:24:19 -0500 In-Reply-To: <52EA1740.2010108@hartkopp.net> Sender: linux-can-owner@vger.kernel.org List-ID: To: Oliver Hartkopp , Eric Dumazet , David Miller Cc: Andre Naujoks , Linux Netdev List , "linux-can@vger.kernel.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WA6A5mqktXmbQBJ6IkS0PDHfQt7VhEOHV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/30/2014 10:11 AM, Oliver Hartkopp wrote: > Self generated skbuffs in net/can/bcm.c are setting a skb->sk reference= but > no explicit destructor which is enforced since Linux 3.11 with commit > 376c7311bdb6 (net: add a temporary sanity check in skb_orphan()). >=20 > This patch adds some helper functions to make sure that a destructor is= > properly defined when a sock reference is assigned to a CAN related skb= =2E > To create an unshared skb owned by the original sock a common helper fu= nction > has been introduced to replace open coded functions to create CAN echo = skbs. >=20 > Signed-off-by: Oliver Hartkopp > Tested-by: Andre Naujoks >=20 > --- >=20 > The patch applies properly down to Linux 3.9. For older kernels the inc= lude > file include/linux/can/skb.h would need to be created. Should I add stable on Cc when applying this patch? Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --WA6A5mqktXmbQBJ6IkS0PDHfQt7VhEOHV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlLqGjgACgkQjTAFq1RaXHP12wCfTBGnc0j+Wzyq72n6XZyiXVxq yYEAn2zOf7PNKLyuWppYyDz3VdAKQOYq =onaU -----END PGP SIGNATURE----- --WA6A5mqktXmbQBJ6IkS0PDHfQt7VhEOHV--