From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAFq0-00075k-No for qemu-devel@nongnu.org; Mon, 03 Feb 2014 04:29:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAFps-0001sx-BY for qemu-devel@nongnu.org; Mon, 03 Feb 2014 04:29:08 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:37612 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAFpr-0001sl-VB for qemu-devel@nongnu.org; Mon, 03 Feb 2014 04:29:00 -0500 Message-ID: <52EF6158.8010801@kamp.de> Date: Mon, 03 Feb 2014 10:28:56 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1389172118-25402-1-git-send-email-pl@kamp.de> In-Reply-To: <1389172118-25402-1-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv4 0/6] ui/vnc: update optimizations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: sw@weilnetz.de, Peter Lieven , xiawenc@linux.vnet.ibm.com, aliguori@amazon.com On 08.01.2014 10:08, Peter Lieven wrote: > this series includes several optimizations for the ui/vnc guest to server and server to client > update cycles. comments/reviews appreciated. > > v3->v4: - patch 1,4,6 unchanged > - patch 2: fix 2 missing changes from 16 -> VNC_DIRTY_PIXELS_PER_BIT [Wenchao] > - patch 3: fixed missing roundup of width in vnc_dpy_switch [Wenchao] > - patch 3: fixed x offset calculation in vnc_refresh_server_surface > - patch 5: fixed missing roundup of width in vnc_dpy_update, cleaned up function > v2->v3: - fixed checkpatch warnings [Stefan] > - fixed an old coding style violation [Stefan] > v1->v2: - new patches 2,4,5 > - patch3: added performance test [Anthony] > - patch3: further optimized the vnc_update_client by searching for the next zero bit > with find_next_zero_bit. > - patch3: further optimized vnc_dpy_switch by using bitmap_set to mask bits dirty. > > Peter Lieven (6): > ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro > ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT > ui/vnc: optimize dirty bitmap tracking > ui/vnc: optimize clearing in find_and_clear_dirty_height() > ui/vnc: optimize setting in vnc_dpy_update() > ui/vnc: disable adaptive update calculations if not needed > > ui/vnc.c | 206 +++++++++++++++++++++++++++++++++++--------------------------- > ui/vnc.h | 10 ++- > 2 files changed, 127 insertions(+), 89 deletions(-) > PingV2 ;-) Peter