All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] watchdog: w83697hf_wdt: return ENODEV if no device was found
@ 2014-01-27  7:04 Stanislav Kholmanskikh
  2014-01-27 16:33 ` Guenter Roeck
  0 siblings, 1 reply; 5+ messages in thread
From: Stanislav Kholmanskikh @ 2014-01-27  7:04 UTC (permalink / raw)
  To: linux-watchdog; +Cc: vasily.isaenko

Most WDT driver modules return ENODEV during modprobe if
no valid device was found, but w83697hf_wdt returns EIO.

Let w83697hf_wdt return ENODEV.

Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 drivers/watchdog/w83697hf_wdt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/watchdog/w83697hf_wdt.c b/drivers/watchdog/w83697hf_wdt.c
index aaf2995..68b45fc 100644
--- a/drivers/watchdog/w83697hf_wdt.c
+++ b/drivers/watchdog/w83697hf_wdt.c
@@ -402,7 +402,7 @@ static int __init wdt_init(void)
 
 	if (!found) {
 		pr_err("No W83697HF/HG could be found\n");
-		ret = -EIO;
+		ret = -ENODEV;
 		goto out;
 	}
 
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] watchdog: w83697hf_wdt: return ENODEV if no device was found
  2014-01-27  7:04 [PATCH] watchdog: w83697hf_wdt: return ENODEV if no device was found Stanislav Kholmanskikh
@ 2014-01-27 16:33 ` Guenter Roeck
  2014-02-06  6:25   ` Stanislav Kholmanskikh
  0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2014-01-27 16:33 UTC (permalink / raw)
  To: Stanislav Kholmanskikh; +Cc: linux-watchdog, vasily.isaenko

On Mon, Jan 27, 2014 at 11:04:33AM +0400, Stanislav Kholmanskikh wrote:
> Most WDT driver modules return ENODEV during modprobe if
> no valid device was found, but w83697hf_wdt returns EIO.
> 
> Let w83697hf_wdt return ENODEV.
> 
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] watchdog: w83697hf_wdt: return ENODEV if no device was found
  2014-01-27 16:33 ` Guenter Roeck
@ 2014-02-06  6:25   ` Stanislav Kholmanskikh
  2014-02-06  7:25     ` Guenter Roeck
  0 siblings, 1 reply; 5+ messages in thread
From: Stanislav Kholmanskikh @ 2014-02-06  6:25 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linux-watchdog, vasily.isaenko

Hi!

On 01/27/2014 08:33 PM, Guenter Roeck wrote:
> On Mon, Jan 27, 2014 at 11:04:33AM +0400, Stanislav Kholmanskikh wrote:
>> Most WDT driver modules return ENODEV during modprobe if
>> no valid device was found, but w83697hf_wdt returns EIO.
>>
>> Let w83697hf_wdt return ENODEV.
>>
>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Thank you.

I'm a newbie here.

Should I do something to move it forward (like send this to an another 
mail list), or just wait? :)

Thanks.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] watchdog: w83697hf_wdt: return ENODEV if no device was found
  2014-02-06  6:25   ` Stanislav Kholmanskikh
@ 2014-02-06  7:25     ` Guenter Roeck
  2014-02-06  7:49       ` Stanislav Kholmanskikh
  0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2014-02-06  7:25 UTC (permalink / raw)
  To: Stanislav Kholmanskikh; +Cc: linux-watchdog, vasily.isaenko

On 02/05/2014 10:25 PM, Stanislav Kholmanskikh wrote:
> Hi!
>
> On 01/27/2014 08:33 PM, Guenter Roeck wrote:
>> On Mon, Jan 27, 2014 at 11:04:33AM +0400, Stanislav Kholmanskikh wrote:
>>> Most WDT driver modules return ENODEV during modprobe if
>>> no valid device was found, but w83697hf_wdt returns EIO.
>>>
>>> Let w83697hf_wdt return ENODEV.
>>>
>>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> Thank you.
>
> I'm a newbie here.
>
> Should I do something to move it forward (like send this to an another mail list), or just wait? :)
>

Just wait. I'll apply it to my tree and send a reminder to Wim at some point.
Usually Wim is pretty good at picking things up himself, though.

Of course, fun part in this case is that I actually submitted a patch
to remove this driver ;-). Not as bad as it sounds - reason was that
the w83627hf driver now supports the w83697hf as well, and the w83697hf
driver is thus redundant. I can understand Wim if he wants to keep
the driver around for a while, though.

Guenter


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] watchdog: w83697hf_wdt: return ENODEV if no device was found
  2014-02-06  7:25     ` Guenter Roeck
@ 2014-02-06  7:49       ` Stanislav Kholmanskikh
  0 siblings, 0 replies; 5+ messages in thread
From: Stanislav Kholmanskikh @ 2014-02-06  7:49 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linux-watchdog, vasily.isaenko



On 02/06/2014 11:25 AM, Guenter Roeck wrote:
> On 02/05/2014 10:25 PM, Stanislav Kholmanskikh wrote:
>> Hi!
>>
>> On 01/27/2014 08:33 PM, Guenter Roeck wrote:
>>> On Mon, Jan 27, 2014 at 11:04:33AM +0400, Stanislav Kholmanskikh wrote:
>>>> Most WDT driver modules return ENODEV during modprobe if
>>>> no valid device was found, but w83697hf_wdt returns EIO.
>>>>
>>>> Let w83697hf_wdt return ENODEV.
>>>>
>>>> Signed-off-by: Stanislav Kholmanskikh
>>>> <stanislav.kholmanskikh@oracle.com>
>>>
>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Thank you.
>>
>> I'm a newbie here.
>>
>> Should I do something to move it forward (like send this to an another
>> mail list), or just wait? :)
>>
>
> Just wait. I'll apply it to my tree and send a reminder to Wim at some
> point.
> Usually Wim is pretty good at picking things up himself, though.
>
> Of course, fun part in this case is that I actually submitted a patch
> to remove this driver ;-). Not as bad as it sounds - reason was that
> the w83627hf driver now supports the w83697hf as well, and the w83697hf
> driver is thus redundant. I can understand Wim if he wants to keep
> the driver around for a while, though.
>

Ok. Got it.

Both outcomes are good for me :)


> Guenter
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-02-06  7:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-27  7:04 [PATCH] watchdog: w83697hf_wdt: return ENODEV if no device was found Stanislav Kholmanskikh
2014-01-27 16:33 ` Guenter Roeck
2014-02-06  6:25   ` Stanislav Kholmanskikh
2014-02-06  7:25     ` Guenter Roeck
2014-02-06  7:49       ` Stanislav Kholmanskikh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.