All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] samba: convert to choice package
Date: Mon, 10 Feb 2014 07:48:37 +0100	[thread overview]
Message-ID: <52F87645.8000708@mind.be> (raw)
In-Reply-To: <1391806354-32698-4-git-send-email-gustavo@zacarias.com.ar>

On 02/07/14 21:52, Gustavo Zacarias wrote:
> Convert the classic samba package to a choice and move it to samba3 in
> preparation for the samba4 package.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

 I don't like this rename. Why not keep the old samba package and add
samba4 to it? If side-by-side installation is not possible, make samba4
depend on !samba, like is done for qt5.

 If you do keep this rename, there are a few things you forgot:

- gvfs has a condition on BR2_PACKAGE_SAMBA_LIBSMBCLIENT;

- you need legacy options for all the samba suboptions.


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2014-02-10  6:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 20:52 [Buildroot] [PATCH 0/4] Samba4 package Gustavo Zacarias
2014-02-07 20:52 ` [Buildroot] [PATCH 1/4] python: fixup python-config script Gustavo Zacarias
2014-02-07 20:52 ` [Buildroot] [PATCH 2/4] heimdal: new package Gustavo Zacarias
2014-02-07 20:52 ` [Buildroot] [PATCH 3/4] samba: convert to choice package Gustavo Zacarias
2014-02-07 22:20   ` Samuel Martin
2014-02-10  6:48   ` Arnout Vandecappelle [this message]
2014-02-10 12:33     ` Thomas Petazzoni
2014-02-07 20:52 ` [Buildroot] [PATCH 4/4] samba4: new package Gustavo Zacarias
2014-02-07 22:29   ` Samuel Martin
2014-02-08  0:00     ` Gustavo Zacarias
2014-02-08 14:30 ` [Buildroot] [PATCH 0/4] Samba4 package Christophe Vu-Brugier
2014-02-10 12:34   ` Thomas Petazzoni
2014-02-10 15:01     ` Christophe Vu-Brugier
2014-02-10 15:05       ` Thomas Petazzoni
2014-02-11 11:59   ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F87645.8000708@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.