From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WD3vJ-0003w3-TA for qemu-devel@nongnu.org; Mon, 10 Feb 2014 22:22:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WD3v9-0000CX-Le for qemu-devel@nongnu.org; Mon, 10 Feb 2014 22:22:13 -0500 Received: from [222.73.24.84] (port=25000 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WD3v9-0000Bv-AJ for qemu-devel@nongnu.org; Mon, 10 Feb 2014 22:22:03 -0500 Message-ID: <52F9970F.7090802@cn.fujitsu.com> Date: Tue, 11 Feb 2014 11:20:47 +0800 From: Qiao Nuohan MIME-Version: 1.0 References: <1390890126-17377-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1390890126-17377-14-git-send-email-qiaonuohan@cn.fujitsu.com> <20140210141048.796e9c91@redhat.com> <52F94C84.20105@redhat.com> <52F95C46.3030701@redhat.com> <52F9611D.7000808@redhat.com> <52F9620D.5040204@redhat.com> <20140210214721.2df300e4@redhat.com> In-Reply-To: <20140210214721.2df300e4@redhat.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Subject: Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: stefanha@gmail.com, qemu-devel@nongnu.org, Luiz Capitulino , kumagai-atsushi@mxc.nes.nec.co.jp, Paolo Bonzini , Laszlo Ersek , afaerber@suse.de, anderson@redhat.com On 02/11/2014 10:47 AM, Luiz Capitulino wrote: > On Tue, 11 Feb 2014 00:34:37 +0100 > Paolo Bonzini wrote: > >> Il 11/02/2014 00:30, Laszlo Ersek ha scritto: >>>>> However, I don't see the point in having the "format-option" field. What >>>>> about: >>>>> >>>>> -> { "execute": "query-dump-guest-memory-capabilities" } >>>>> <- { "return": { "formats": >>>>> ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] } >>> Technically you might be right. However, this partial introspection >>> feature is entirely a wart >> >> I don't see it entirely like that. For example, whether paging is >> supported could also be part of the capabilities and not part of the >> regular QAPI introspection. Of course, quiaonuohan need not add >> anything like that. >> >>> whose existence is exclusively justified by >>> non-technical reasons, such as deadlines, and not wanting to be blocked >>> indefinitely by architecture astronautics around full introspection. I >>> don't see the point of polishing it beyond bare usability, at least not >>> after I've reviewed three versions of the patchset. >> >> Luiz, can you apply patches 1-12 for now? I agree with Laszlo that, no >> matter how unfortunate this is, the "unused" warnings are a necessary >> evil and one that can be worked around easily when bisecting. > > Yes, I can. But what's the problem with patch 13? For me having Eric's > ACK is enough for applying it. Anything else will be done by QMP > introspection. > Hello Eric, Need your review here, thanks a lot!! -- Regards Qiao Nuohan