From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Devesh Sharma
<Devesh.Sharma-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org>,
Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Selvin Xavier
<Selvin.Xavier-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH for-next 15/17] RDMA/ocrdma: Support for Skyhawk statistics
Date: Tue, 11 Feb 2014 09:57:21 +0200 [thread overview]
Message-ID: <52F9D7E1.8050700@mellanox.com> (raw)
In-Reply-To: <424c56ee-b168-48e2-a298-f30a326ee8d0-3RiH6ntJJkP8BX6JNMqfyFjyZtpTMMwT@public.gmane.org>
On 08/02/2014 06:26, Devesh Sharma wrote:
> We are having some 200 Odds vendor specific stats to be displayed. With sysfs infrastructure for IB devices [..] We had a discussion with Roland on this, and he gave us a go-ahead on this as well.
Roland, what's wrong with either plugging into the framework for IB
statistics set by commit 7f624d023b5fb "RDMA/core: Add iWARP protocol
statistics attributes in sysfs" for the IBTA defined statistics and have
the vendor propeitary stats to be reported through the rdma netlink
code, or having it all go through netlink (better to my taste).
Or.
> we found that each stat will correspond to one file in sysfs tree therefore it will constitute a large number of files in ocrdma tree per port, situation will worsen if SRIOV and Multichannel comes into picture, On the other hand, with debugfs it is possible to have one file displaying multiple stats thus, drastically reducing the number of sysfs file entries.
>
> We had a discussion with Roland on this, and he gave us a go-ahead on this as well.
> However, if you still think we should honor IB-diag infra, we are open to populate IB-compliant stats into that framework as well along with debugfs entries.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-11 7:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391495230-28021-1-git-send-email-devesh.sharma@emulex.com>
[not found] ` <1391495230-28021-1-git-send-email-devesh.sharma-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>
2014-02-04 6:26 ` [PATCH for-next 01/17] RDMA/ocrdma: Eq full catastrophe avoidance Devesh Sharma
2014-02-04 6:26 ` [PATCH for-next 02/17] RDMA/ocrdma: SQ and RQ doorbell offset clean up Devesh Sharma
2014-02-04 6:26 ` [PATCH for-next 03/17] RDMA/ocrdma: read ASIC_ID register to select asic_gen Devesh Sharma
2014-02-04 6:26 ` [PATCH for-next 04/17] RDMA/ocrdma: Allow DPP QP creation Devesh Sharma
2014-02-04 6:26 ` [PATCH for-next 05/17] RDMA/ocrdma: ABI versioning between ocrdma and be2net Devesh Sharma
2014-02-04 6:26 ` [PATCH for-next 06/17] be2net: adding abi version between be2net and ocrdma Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 07/17] RDMA/ocrdma: update version string Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 08/17] RDMA/ocrdma: increment abi version count Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 09/17] RDMA/ocrdma: Memory leak fix in ocrdma_dereg_mr Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 10/17] RDMA/ocrdma: Use non zero tag in SRQ posting Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 11/17] RDMA/ocrdma: Display proper value for max_mw Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 12/17] RDMA/ocrdma: Handle CQ overrun error Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 13/17] RDMA/ocrdma: Support non-embedded mailbox commands Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 14/17] RDMA/ocrdma: Query controller information Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 15/17] RDMA/ocrdma: Support for Skyhawk statistics Devesh Sharma
[not found] ` <CAJZOPZK-w98t0=K4AUceKPCbwjd75BBjG325YgbQ-iV-ETosPg@mail.gmail.com>
[not found] ` <CAJZOPZK-w98t0=K4AUceKPCbwjd75BBjG325YgbQ-iV-ETosPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-06 21:07 ` Or Gerlitz
[not found] ` <CAJZOPZ+ajdDtehBJnwUGA5mgMM2aDn1JsY=0Pas3Se-WfZYs4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-08 4:26 ` Devesh Sharma
[not found] ` <424c56ee-b168-48e2-a298-f30a326ee8d0-3RiH6ntJJkP8BX6JNMqfyFjyZtpTMMwT@public.gmane.org>
2014-02-08 19:16 ` Jason Gunthorpe
[not found] ` <20140208191633.GA24320-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2014-02-14 6:16 ` Devesh Sharma
2014-02-11 7:57 ` Or Gerlitz [this message]
2014-02-04 6:27 ` [PATCH for-next 16/17] RDMA/ocrdma: Display fw version Devesh Sharma
2014-02-04 6:27 ` [PATCH for-next 17/17] RDMA/ocrdma: code clean-up Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F9D7E1.8050700@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=Devesh.Sharma-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org \
--cc=Selvin.Xavier-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.