All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V4 2/2] i.MX: Update versions to match latest Freescale release
Date: Wed, 12 Feb 2014 13:20:02 -0700	[thread overview]
Message-ID: <52FBD772.40900@boundarydevices.com> (raw)
In-Reply-To: <52FBC72D.3090706@boundarydevices.com>

Hello Yann,

On 02/12/2014 12:10 PM, Eric Nelson wrote:
> Hi Yann,
>
> On 02/12/2014 12:03 PM, Yann E. MORIN wrote:
>> Eric, All,
>>
>> A (hopefully!) better review this time...
>>
>> On 2013-10-08 20:05 -0700, Eric Nelson spake thusly:
>>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
 >>>
 >>> [--SNIP--]
 >>>
>>> +# The archive is a shell-self-extractor of a bzipped tar. It happens
>>> +# to extract in the correct directory (imx-lib-x.y.z)
>>> +# The --force makes sure it doesn't fail if the source dir already
>>> exists.
>>> +# The --auto-accept skips the license check - not needed for us
>>> +# because we have legal-info
>>> +# Since there's a EULA in the bin file, extract it to
>>> imx-lib-x.y.z/EULA
>>> +#
>>> +define IMX_LIB_EXTRACT_CMDS
>>> +    awk 'BEGIN      { start=0; } \
>>> +         /^EOEULA/  { start = 0; } \
>>> +                    { if (start) print; } \
>>> +         /<<EOEULA/ { start=1; }'\
>>> +        $(DL_DIR)/$(IMX_LIB_SOURCE) > $(@D)/EULA
>>> +    cd $(BUILD_DIR); \
>>> +    sh $(DL_DIR)/$(IMX_LIB_SOURCE) --force --auto-accept
>>> +endef
>>
>>      $ make imx-lib-extract
>>      [...]
>>      Unpacking file mkdir: cannot create directory ?imx-lib-3.5.7-1.0.0?:
>>      File exists
>>
>> This is only a warning, but still: maybe extract the EULA _after_
>> unpacking the archive?
>>
>
> Sure. I'll re-work.
>

Re-arranging these commands doesn't get rid of the warning.

It appears that the directory is created by the bit of
structure using IMX_LIB_EXTRACT_CMDS, and the warning
message is from a 'mkdir' embedded within the self-extracting
package.

I could 'rm' the directory inside IMX_LIB_EXTRACT_CMDS,
but it's not clear that this is the right thing to do.

Please let me know your thoughts on the matter.

Regards,


Eric

  reply	other threads:[~2014-02-12 20:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09  3:05 [Buildroot] [PATCH V4 0/2] i.MX updates Eric Nelson
2013-10-09  3:05 ` [Buildroot] [PATCH V4 1/2] i.MX: Use FREESCALE_IMX_SITE for Freescale packages Eric Nelson
2014-02-12 18:10   ` Yann E. MORIN
2014-02-12 19:01     ` Eric Nelson
2013-10-09  3:05 ` [Buildroot] [PATCH V4 2/2] i.MX: Update versions to match latest Freescale release Eric Nelson
2014-02-12 18:23   ` Yann E. MORIN
2014-02-12 18:27     ` Yann E. MORIN
2014-02-12 19:03   ` Yann E. MORIN
2014-02-12 19:10     ` Eric Nelson
2014-02-12 20:20       ` Eric Nelson [this message]
2014-02-12 21:58         ` Arnout Vandecappelle
2014-02-12 22:15           ` Mike Zick
2014-02-12 22:55             ` Eric Nelson
2014-02-12 23:53               ` Eric Nelson
2014-02-12 23:59                 ` Yann E. MORIN
2014-02-12 22:20           ` Peter Korsgaard
2014-02-12 22:45             ` Eric Nelson
2014-02-12 23:41         ` Yann E. MORIN
2014-02-13  2:00           ` Eric Nelson
2014-02-13 22:52             ` Yann E. MORIN
2014-02-13 22:54               ` Thomas Petazzoni
2014-02-14  0:34                 ` Eric Nelson
2014-02-14  0:31               ` Eric Nelson
2014-02-12 23:25       ` Eric Nelson
2014-02-12 23:46         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FBD772.40900@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.