From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Gleb Natapov <gleb@kernel.org>
Cc: KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Michael Mueller <mimu@linux.vnet.ibm.com>
Subject: Re: [PATCH/RFC 2/3] s390/kvm: Platform specific kvm_arch_vcpu_dont_yield
Date: Fri, 14 Feb 2014 00:32:24 +0100 [thread overview]
Message-ID: <52FD5608.2050808@redhat.com> (raw)
In-Reply-To: <52FD4D17.10307@de.ibm.com>
Il 13/02/2014 23:54, Christian Borntraeger ha scritto:
> We had several variants but in the end we tried to come up with a patch that does not
> influence other architectures. Your proposal would certainly be fine for s390,
> but what impact does it have on x86, arm, arm64? Will it cause performance regressions?
It may also have the same advantages you got on s390.
> So I think that the patch as is is probably the safest choice until we have some
> data from x86, arm, arm64, no?
No, using an existing API is always better than inventing a new one.
If you post the new patch series, and describe the benchmark you were
using, we can reproduce it on x86.
Paolo
next prev parent reply other threads:[~2014-02-13 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 11:45 [PATCH/RFC 0/3] KVM: yield heuristic improvements Christian Borntraeger
2014-02-11 11:45 ` [PATCH/RFC 1/3] kvm: Introduction of kvm_arch_vcpu_dont_yield() Christian Borntraeger
2014-02-11 11:45 ` [PATCH/RFC 2/3] s390/kvm: Platform specific kvm_arch_vcpu_dont_yield Christian Borntraeger
2014-02-13 22:37 ` Paolo Bonzini
2014-02-13 22:54 ` Christian Borntraeger
2014-02-13 23:32 ` Paolo Bonzini [this message]
2014-02-14 9:55 ` Christian Borntraeger
2014-02-14 9:56 ` Paolo Bonzini
2014-02-24 14:22 ` Michael Mueller
2014-02-11 11:45 ` [PATCH/RFC 3/3] s390/kvm: Set preempted flag during vcpu wakeup and interrupt delivery Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FD5608.2050808@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mimu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.