From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEHR4-0008Iv-BZ for qemu-devel@nongnu.org; Fri, 14 Feb 2014 07:00:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEHQw-0002K5-0a for qemu-devel@nongnu.org; Fri, 14 Feb 2014 07:00:02 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44988 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEHQv-0002Jj-NK for qemu-devel@nongnu.org; Fri, 14 Feb 2014 06:59:53 -0500 Message-ID: <52FE0535.2090205@suse.de> Date: Fri, 14 Feb 2014 12:59:49 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1381982022-19291-1-git-send-email-rusty@rustcorp.com.au> <20140214103802.4631d238@bahia.local> In-Reply-To: <20140214103802.4631d238@bahia.local> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , Marc Zyngier , Rusty Russell , Stefan Hajnoczi , Alexander Graf , Anthony Liguori , Paolo Bonzini Hi, Am 14.02.2014 10:38, schrieb Greg Kurz: > On Thu, 17 Oct 2013 14:23:35 +1030 > Rusty Russell wrote: >> This is a re-transmit of the core of the virtio endian code. Since >> there seems to be some interest in ARM BE virtio, I've separated this = from >> the direct problem I was solving: PowerPC LE. >> >> Please apply! >> Rusty. >> >=20 > Hi, >=20 > This serie is needed to enable current legacy virtio devices in a > cross-endian environment. Even though virtio-1.0 will address endianess > questions at the specification level, it is still in its early boot pha= se > and no code will be available before long (Rusty, please correct me if = I am > wrong). >=20 > We have all the PPC KVM bits in 3.14 already. We have PPC QEMU patches > ready to be applied by Alexander, as soon as the common code gets in. > Anthony has already positively reviewed this serie. We have been testin= g > for some monthes... Now we are waiting for partners ! :) >=20 > Are the ARM people still interested in cross-endian virtio ? Are there > other people interested (Thomas for s390) ? >=20 > If so, please participate or we will have to wait for the new standard = to be > finalized and implemented... :-\ It might've helped if Rusty had actually used our scripts/get_maintainer.pl script to CC people. While Anthony seems to have reviewed some patches (usually Reviewed-by should be before the final Signed-off-by fwiw), neither Stefan (virtio-net) nor Kevin (virtio-blk) nor Paolo (virtio-scsi) were CC'ed, and recently Michael stepped up as virtio maintainer, so maybe he can take them once ready. 1/7 looks okay to me; 3-7 are rather mechanical - people will need to review that those changes are sufficient for the current code base. We've since converted virtio devices to QOM realize, so a rebase is likely needed for such an "old" series. Regards, Andreas >> Rusty Russell (7): >> virtio_get_byteswap: function for endian-ambivalent targets using >> virtio. >> virtio: allow byte swapping for vring and config access >> hw/net/virtio-net: use virtio wrappers to access headers. >> hw/net/virtio-balloon: use virtio wrappers to access page frame >> numbers. >> hw/block/virtio-blk: use virtio wrappers to access headers. >> hw/scsi/virtio-scsi: use virtio wrappers to access headers. >> hw/char/virtio-serial-bus: use virtio wrappers to access headers. >> >> hw/block/virtio-blk.c | 35 +++++----- >> hw/char/virtio-serial-bus.c | 34 +++++----- >> hw/net/virtio-net.c | 15 +++-- >> hw/scsi/virtio-scsi.c | 33 +++++----- >> hw/virtio/virtio-balloon.c | 3 +- >> hw/virtio/virtio.c | 34 ++++++---- >> include/hw/virtio/virtio-access.h | 133 >> ++++++++++++++++++++++++++++++++++++++ include/hw/virtio/virtio.h >> | 2 + stubs/Makefile.objs | 1 + >> stubs/virtio_get_byteswap.c | 6 ++ >> 10 files changed, 225 insertions(+), 71 deletions(-) >> create mode 100644 include/hw/virtio/virtio-access.h >> create mode 100644 stubs/virtio_get_byteswap.c --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg