From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Elder <elder@ieee.org>
Subject: Re: [PATCH 1/3] ceph: make ceph_forget_all_cached_acls() static inline
Date: Fri, 14 Feb 2014 06:29:57 -0600
Message-ID: <52FE0C45.4070708@ieee.org>
References: <1392355784-10422-1-git-send-email-lucienchao@gmail.com> <1392355784-10422-2-git-send-email-lucienchao@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <ceph-devel-owner@vger.kernel.org>
Received: from mail-ig0-f177.google.com ([209.85.213.177]:52768 "EHLO
	mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751312AbaBNM36 (ORCPT
	<rfc822;ceph-devel@vger.kernel.org>); Fri, 14 Feb 2014 07:29:58 -0500
Received: by mail-ig0-f177.google.com with SMTP id k19so738414igc.4
        for <ceph-devel@vger.kernel.org>; Fri, 14 Feb 2014 04:29:58 -0800 (PST)
In-Reply-To: <1392355784-10422-2-git-send-email-lucienchao@gmail.com>
Sender: ceph-devel-owner@vger.kernel.org
List-ID: <ceph-devel.vger.kernel.org>
To: Guangliang Zhao <lucienchao@gmail.com>, ceph-devel@vger.kernel.org
Cc: sage@inktank.com

On 02/13/2014 11:29 PM, Guangliang Zhao wrote:
> Signed-off-by: Guangliang Zhao <lucienchao@gmail.com>

Looks good.  Is there a reason we can't just call
forget_all_cached_acls(inode) directly?  Or is it
just so that we have our own complete private ACL
interface?  (I have no problem with it, just asking.)

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
>  fs/ceph/acl.c   |    5 -----
>  fs/ceph/super.h |    6 +++++-
>  2 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/ceph/acl.c b/fs/ceph/acl.c
> index 64fddbc..48af0b3 100644
> --- a/fs/ceph/acl.c
> +++ b/fs/ceph/acl.c
> @@ -54,11 +54,6 @@ static inline struct posix_acl *ceph_get_cached_acl(struct inode *inode,
>  	return acl;
>  }
>  
> -void ceph_forget_all_cached_acls(struct inode *inode)
> -{
> -	forget_all_cached_acls(inode);
> -}
> -
>  struct posix_acl *ceph_get_acl(struct inode *inode, int type)
>  {
>  	int size;
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index c299f7d..8851dc2 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -13,6 +13,7 @@
>  #include <linux/wait.h>
>  #include <linux/writeback.h>
>  #include <linux/slab.h>
> +#include <linux/posix_acl.h>
>  
>  #include <linux/ceph/libceph.h>
>  
> @@ -745,7 +746,10 @@ extern const struct xattr_handler *ceph_xattr_handlers[];
>  struct posix_acl *ceph_get_acl(struct inode *, int);
>  int ceph_init_acl(struct dentry *, struct inode *, struct inode *);
>  int ceph_acl_chmod(struct dentry *, struct inode *);
> -void ceph_forget_all_cached_acls(struct inode *inode);
> +static inline void ceph_forget_all_cached_acls(struct inode *inode)
> +{
> +	forget_all_cached_acls(inode);
> +}
>  
>  #else
>  
>