All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <elder@ieee.org>
To: Guangliang Zhao <lucienchao@gmail.com>, ceph-devel@vger.kernel.org
Cc: sage@inktank.com
Subject: Re: [PATCH 3/3] ceph: make ceph ACL for symlink inheritable
Date: Fri, 14 Feb 2014 07:06:10 -0600	[thread overview]
Message-ID: <52FE14C2.7030805@ieee.org> (raw)
In-Reply-To: <1392355784-10422-4-git-send-email-lucienchao@gmail.com>

On 02/13/2014 11:29 PM, Guangliang Zhao wrote:
> Default ACL couldn't be inherited by the symlink in the
> parent directory. This resolve it.

This looks good to me, and it seems to be consistent
with what other file systems do.

Reviewed-by: Alex Elder <elder@linaro.org>

> Signed-off-by: Guangliang Zhao <lucienchao@gmail.com>
> ---
>  fs/ceph/dir.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
> index 619616d..2650570 100644
> --- a/fs/ceph/dir.c
> +++ b/fs/ceph/dir.c
> @@ -735,6 +735,10 @@ static int ceph_symlink(struct inode *dir, struct dentry *dentry,
>  	if (!err && !req->r_reply_info.head->is_dentry)
>  		err = ceph_handle_notrace_create(dir, dentry);
>  	ceph_mdsc_put_request(req);
> +
> +	if (!err)
> +		err = ceph_init_acl(dentry, dentry->d_inode, dir);
> +
>  	if (err)
>  		d_drop(dentry);
>  	return err;
> 


  reply	other threads:[~2014-02-14 13:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14  5:29 [PATCH 0/3] several misc patches Guangliang Zhao
2014-02-14  5:29 ` [PATCH 1/3] ceph: make ceph_forget_all_cached_acls() static inline Guangliang Zhao
2014-02-14 12:29   ` Alex Elder
2014-02-16 18:27     ` Sage Weil
2014-02-14  5:29 ` [PATCH 2/3] ceph: add acl, noacl options for cephfs mount Guangliang Zhao
2014-02-14 13:00   ` Alex Elder
2014-02-16 18:26     ` Sage Weil
2014-02-17 14:27       ` Guangliang Zhao
2014-02-18  0:08       ` Alex Elder
2014-02-14  5:29 ` [PATCH 3/3] ceph: make ceph ACL for symlink inheritable Guangliang Zhao
2014-02-14 13:06   ` Alex Elder [this message]
2014-02-16 18:27     ` Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FE14C2.7030805@ieee.org \
    --to=elder@ieee.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=lucienchao@gmail.com \
    --cc=sage@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.