From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42675)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sebastian.huber@embedded-brains.de>)
	id 1WEKvm-0002A0-BY
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 10:44:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sebastian.huber@embedded-brains.de>)
	id 1WEKvh-0003zU-B9
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 10:43:58 -0500
Received: from host-82-135-62-35.customer.m-online.net ([82.135.62.35]:49300
	helo=mail.embedded-brains.de) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sebastian.huber@embedded-brains.de>)
	id 1WEKvh-0003yC-06
	for qemu-devel@nongnu.org; Fri, 14 Feb 2014 10:43:53 -0500
Message-ID: <52FE39B1.1020506@embedded-brains.de>
Date: Fri, 14 Feb 2014 16:43:45 +0100
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
MIME-Version: 1.0
References: <1392391000-5687-1-git-send-email-sebastian.huber@embedded-brains.de>
	<52FE3761.7020403@suse.de>
In-Reply-To: <52FE3761.7020403@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use
	CPU_FEATURE_CASA
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, Fabien Chouteau <chouteau@adacore.com>

On 2014-02-14 16:33, Andreas F=C3=A4rber wrote:
>> @@ -5120,6 +5119,20 @@ static void disas_sparc_insn(DisasContext * dc,=
 unsigned int insn)
>> >                  case 0x37: /* stdc */
>> >                      goto ncp_insn;
>> >  #endif
>> >+#if !defined(CONFIG_USER_ONLY) || defined(TARGET_SPARC64)
>> >+                case 0x3c: /* V9 or LEON3 casa */
>> >+                    CHECK_FPU_FEATURE(dc, CASA);
>> >+#ifndef TARGET_SPARC64
>> >+                    if (IS_IMM)
>
> Did you forget to run checkpatch.pl? Missing braces here ...
>
>> >+                        goto illegal_insn;
>> >+                    if (!supervisor(dc))
> ... and here.
>
>> >+                        goto priv_insn;
> Otherwise patch looks okay, thanks for the subject normalization.

I didn't know there was a checkpatch.pl, I run it next time.

This code fragment is a copy and paste move from another place in this fi=
le.=20
There a lot of similar style errors in this file.

>
> As for the other one you'll need to sort our who sends a pull if Blue
> doesn't resurface - I note that qemu-trivial is not CC'ed here and the
> patch probably isn't anyway. Maybe Fabien can help out with that?
>
> More generally, independent of this patch with test case in its commit
> message, you may want to consider setting up tests/tcg/sparc/ for test
> cases and/or use qtest with accel=3Dtcg similar to what mst did for ACP=
I
> regression testing.

Ok, I will have a look at this.  Is this a required step to get the patch=
=20
committed?

--=20
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG=
.