All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wang Weidong <wangweidong1@huawei.com>,
	acme@ghostprotocols.net, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/4] appletalk: convert printks to pr_<level>
Date: Sat, 15 Feb 2014 00:45:53 +0300	[thread overview]
Message-ID: <52FE8E91.2040105@cogentembedded.com> (raw)
In-Reply-To: <1392363826-8256-4-git-send-email-wangweidong1@huawei.com>

Hello.

On 02/14/2014 10:43 AM, Wang Weidong wrote:

> Prefer pr_<level> then printk(LEVEL).

> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>

[...]
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
> index 06e0d19..9189d3c 100644
> --- a/net/appletalk/ddp.c
> +++ b/net/appletalk/ddp.c
> @@ -704,9 +704,9 @@ static int atif_ioctl(int cmd, void __user *arg)
>   		if ((dev->flags & IFF_POINTOPOINT) &&
>   		    atalk_find_interface(sa->sat_addr.s_net,
>   					 sa->sat_addr.s_node)) {
> -			printk(KERN_DEBUG "AppleTalk: point-to-point "
> -			       "interface added with "
> -			       "existing address\n");
> +			pr_debug("AppleTalk: point-to-point "
> +				 "interface added with "
> +				 "existing address\n");
>   			add_route = 0;
>   		}
>
[...]
> @@ -1329,8 +1328,8 @@ static int atalk_route_packet(struct sk_buff *skb, struct net_device *dev,
>   		 * needs to be broadcast onto the default network?
>   		 */
>   		if (dev->type == ARPHRD_PPP)
> -			printk(KERN_DEBUG "AppleTalk: didn't forward broadcast "
> -					  "packet received from PPP iface\n");
> +			pr_debug("AppleTalk: didn't forward broadcast "
> +				 "packet received from PPP iface\n");

    pr_debug() is not equivalent to printk(KERN_DEBUG). It will only print a 
message if DEBUG is defined or if dynamic debugging is enabled.

WBR, Sergei

  parent reply	other threads:[~2014-02-14 20:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14  7:43 [PATCH net-next 0/4] appletalk: fix checkpatch errors or warning Wang Weidong
2014-02-14  7:43 ` [PATCH net-next 1/4] appletalk: fix checkpatch errors with space required or prohibited Wang Weidong
2014-02-14 21:21   ` David Miller
2014-02-14  7:43 ` [PATCH net-next 2/4] appletalk: fix checkpatch errors with foo* bar|foo * bar Wang Weidong
2014-02-14 21:21   ` David Miller
2014-02-14  7:43 ` [PATCH net-next 3/4] appletalk: convert printks to pr_<level> Wang Weidong
2014-02-14 21:21   ` David Miller
2014-02-14 21:45   ` Sergei Shtylyov [this message]
2014-02-15  1:19     ` Wang Weidong
2014-02-14  7:43 ` [PATCH net-next 4/4] appletalk: fix checkpatch error with indent Wang Weidong
2014-02-14 21:21   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FE8E91.2040105@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=acme@ghostprotocols.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=wangweidong1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.