From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:56143 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752267AbeB1NUq (ORCPT ); Wed, 28 Feb 2018 08:20:46 -0500 Received: by mail-wm0-f66.google.com with SMTP id q83so4950746wme.5 for ; Wed, 28 Feb 2018 05:20:46 -0800 (PST) Subject: Re: [PATCH net-next v2 5/5] ipv6: route: dissect flow in input path if fib rules need it To: Roopa Prabhu , davem@davemloft.net, netdev@vger.kernel.org Cc: dsa@cumulusnetworks.com, idosch@mellanox.com, pabeni@redhat.com References: <1519789965-3465-1-git-send-email-roopa@cumulusnetworks.com> <1519789965-3465-6-git-send-email-roopa@cumulusnetworks.com> From: Nikolay Aleksandrov Message-ID: <52a0b194-0f95-c285-cf1d-7a8b786678b8@cumulusnetworks.com> Date: Wed, 28 Feb 2018 15:20:43 +0200 MIME-Version: 1.0 In-Reply-To: <1519789965-3465-6-git-send-email-roopa@cumulusnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 28/02/18 05:52, Roopa Prabhu wrote: > From: Roopa Prabhu > > Dissect flow in fwd path if fib rules require it. Controlled by > a flag to avoid penatly for the common case. Flag is set when fib > rules with sport, dport and proto match that require flow dissect > are installed. Also passes the dissected hash keys to the multipath > hash function when applicable to avoid dissecting the flow again. > icmp packets will continue to use inner header for hash > calculations. > > Signed-off-by: Roopa Prabhu > --- > include/net/ip6_fib.h | 25 +++++++++++++++++++++++++ > include/net/ip6_route.h | 4 +++- > include/net/netns/ipv6.h | 3 ++- > net/ipv6/fib6_rules.c | 16 ++++++++++++++++ > net/ipv6/icmp.c | 2 +- > net/ipv6/route.c | 34 +++++++++++++++++++++++++--------- > 6 files changed, 72 insertions(+), 12 deletions(-) > Looks good, Acked-by: Nikolay Aleksandrov