From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Nicolai_H=c3=a4hnle?= Subject: Re: [PATCH 1/2] drm/amdgpu: guarantee bijective mapping of ring ids for LRU Date: Tue, 28 Mar 2017 17:22:38 +0200 Message-ID: <52a0beab-24e6-c815-87e6-2a4bae133b61@gmail.com> References: <20170327223607.2878-1-andresx7@gmail.com> <20170327223607.2878-2-andresx7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170327223607.2878-2-andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Andres Rodriguez , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org T24gMjguMDMuMjAxNyAwMDozNiwgQW5kcmVzIFJvZHJpZ3VleiB3cm90ZToKPiBEZXBlbmRpbmcg b24gdXNhZ2UgcGF0dGVybnMsIHRoZSBjdXJyZW50IExSVSBwb2xpY3kgbWF5IGNyZWF0ZSBhCj4g bm9uLWluamVjdGl2ZSBtYXBwaW5nIGJldHdlZW4gdXNlcnNwYWNlIHJpbmcgaWRzIGFuZCBrZXJu ZWwgcmluZ3MuCj4KPiBUaGlzIGJlaGF2aW91ciBpcyB1bmRlc2lyZWQgYXMgYXBwcyB0aGF0IGF0 dGVtcHQgdG8gZmlsbCBhbGwgSFcgYmxvY2tzCj4gd291bGQgYmUgdW5hYmxlIHRvIHJlYWNoIHNv bWUgb2YgdGhlbS4KPgo+IFRoaXMgY2hhbmdlIGZvcmNlcyB0aGUgTFJVIHBvbGljeSB0byBjcmVh dGUgYmlqZWN0aXZlIG1hcHBpbmdzIG9ubHkuCj4KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXMgUm9k cmlndWV6IDxhbmRyZXN4N0BnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9xdWV1ZV9tZ3IuYyB8IDE2ICsrKysrKysrKysrLS0KPiAgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3JpbmcuYyAgICAgIHwgMzMgKysrKysrKysrKysrKysr KysrKysrLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yaW5nLmgg ICAgICB8ICA0ICsrLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCAxMSBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfcXVldWVfbWdyLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcXVl dWVfbWdyLmMKPiBpbmRleCAwNTRkNzUwLi5jNjI3NWI0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9xdWV1ZV9tZ3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9xdWV1ZV9tZ3IuYwo+IEBAIC0xMDgsMjQgKzEwOCwzNiBA QCBzdGF0aWMgZW51bSBhbWRncHVfcmluZ190eXBlIGFtZGdwdV9od19pcF90b19yaW5nX3R5cGUo aW50IGh3X2lwKQo+ICAJCURSTV9FUlJPUigiSW52YWxpZCBIVyBJUCBzcGVjaWZpZWQgJWRcbiIs IGh3X2lwKTsKPiAgCQlyZXR1cm4gLTE7Cj4gIAl9Cj4gIH0KPgo+ICBzdGF0aWMgaW50IGFtZGdw dV9scnVfbWFwKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAJCQkgIHN0cnVjdCBhbWRn cHVfcXVldWVfbWFwcGVyICptYXBwZXIsCj4gIAkJCSAgaW50IHVzZXJfcmluZywKPiAgCQkJICBz dHJ1Y3QgYW1kZ3B1X3JpbmcgKipvdXRfcmluZykKPiAgewo+IC0JaW50IHI7Cj4gKwlpbnQgciwg aSwgajsKPiAgCWludCByaW5nX3R5cGUgPSBhbWRncHVfaHdfaXBfdG9fcmluZ190eXBlKG1hcHBl ci0+aHdfaXApOwo+ICsJaW50IHJpbmdfYmxhY2tsaXN0W0FNREdQVV9NQVhfUklOR1NdOwo+ICsJ c3RydWN0IGFtZGdwdV9yaW5nICpyaW5nOwo+Cj4gLQlyID0gYW1kZ3B1X3JpbmdfbHJ1X2dldChh ZGV2LCByaW5nX3R5cGUsIG91dF9yaW5nKTsKPiArCS8qIDAgaXMgYSB2YWxpZCByaW5nIGluZGV4 LCBzbyBpbml0aWFsaXplIHRvIC0xICovCj4gKwltZW1zZXQocmluZ19ibGFja2xpc3QsIDB4ZmYs IHNpemVvZihyaW5nX2JsYWNrbGlzdCkpOwoKVW5sZXNzIEknbSBtaXN0YWtlbiwgeW91IGRvbid0 IG5lZWQgdGhpcyBpZiAuLi4KCgo+ICsKPiArCWZvciAoaSA9IDAsIGogPSAwOyBpIDwgQU1ER1BV X01BWF9SSU5HUzsgaSsrKSB7Cj4gKwkJcmluZyA9IG1hcHBlci0+cXVldWVfbWFwW2ldOwo+ICsJ CWlmIChyaW5nKQo+ICsJCQlyaW5nX2JsYWNrbGlzdFtqKytdID0gcmluZy0+aWR4Owo+ICsJfQo+ ICsKPiArCXIgPSBhbWRncHVfcmluZ19scnVfZ2V0KGFkZXYsIHJpbmdfdHlwZSwgcmluZ19ibGFj a2xpc3QsCj4gKwkJCQlBTURHUFVfTUFYX1JJTkdTLCBvdXRfcmluZyk7CgouLi4geW91IHMvQU1E R1BVX01BWF9SSU5HUy9qLyBoZXJlLgoKCj4gIAlpZiAocikKPiAgCQlyZXR1cm4gcjsKPgo+ICAJ cmV0dXJuIGFtZGdwdV91cGRhdGVfY2FjaGVkX21hcChtYXBwZXIsIHVzZXJfcmluZywgKm91dF9y aW5nKTsKPiAgfQo+Cj4gIC8qKgo+ICAgKiBhbWRncHVfcXVldWVfbWdyX2luaXQgLSBpbml0IGFu IGFtZGdwdV9xdWV1ZV9tZ3Igc3RydWN0Cj4gICAqCj4gICAqIEBhZGV2OiBhbWRncHVfZGV2aWNl IHBvaW50ZXIKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X3JpbmcuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yaW5nLmMKPiBpbmRl eCBjYTQxYjNhLi4yMmM1YjI4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9yaW5nLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfcmluZy5jCj4gQEAgLTM5Myw0NiArMzkzLDY1IEBAIHZvaWQgYW1kZ3B1X3JpbmdfZmluaShz dHJ1Y3QgYW1kZ3B1X3JpbmcgKnJpbmcpCj4gIAlyaW5nLT5hZGV2LT5yaW5nc1tyaW5nLT5pZHhd ID0gTlVMTDsKPiAgfQo+Cj4gIHN0YXRpYyB2b2lkIGFtZGdwdV9yaW5nX2xydV90b3VjaF9sb2Nr ZWQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gIAkJCQkJIHN0cnVjdCBhbWRncHVfcmlu ZyAqcmluZykKPiAgewo+ICAJLyogbGlzdF9tb3ZlX3RhaWwgaGFuZGxlcyB0aGUgY2FzZSB3aGVy ZSByaW5nIGlzbid0IHBhcnQgb2YgdGhlIGxpc3QgKi8KPiAgCWxpc3RfbW92ZV90YWlsKCZyaW5n LT5scnVfbGlzdCwgJmFkZXYtPnJpbmdfbHJ1X2xpc3QpOwo+ICB9Cj4KPiArc3RhdGljIGJvb2wg YW1kZ3B1X3JpbmdfaXNfYmxhY2tsaXN0ZWQoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nLAo+ICsJ CQkJICAgICAgIGludCAqYmxhY2tsaXN0LCBpbnQgbnVtX2JsYWNrbGlzdCkKPiArewo+ICsJaW50 IGk7Cj4gKwo+ICsJZm9yIChpID0gMDsgaSA8IG51bV9ibGFja2xpc3QgJiYgYmxhY2tsaXN0W2ld ICE9IC0xOyBpKyspIHsKCi4uLiBhbmQgdGhlbiB5b3UgY2FuIGFsc28gZHJvcCB0aGUgYmxhY2ts aXN0W2ldICE9IC0xIGhlcmUuCgpXaXRoIHRob3NlIGNoYW5nZXM6CgpSZXZpZXdlZC1ieTogTmlj b2xhaSBIw6RobmxlIDxuaWNvbGFpLmhhZWhubGVAYW1kLmNvbT4KCgo+ICsJCWlmIChyaW5nLT5p ZHggPT0gYmxhY2tsaXN0W2ldKQo+ICsJCQlyZXR1cm4gdHJ1ZTsKPiArCX0KPiArCj4gKwlyZXR1 cm4gZmFsc2U7Cj4gK30KPiArCj4gIC8qKgo+ICAgKiBhbWRncHVfcmluZ19scnVfZ2V0IC0gZ2V0 IHRoZSBsZWFzdCByZWNlbnRseSB1c2VkIHJpbmcgZm9yIGEgSFcgSVAgYmxvY2sKPiAgICoKPiAg ICogQGFkZXY6IGFtZGdwdV9kZXZpY2UgcG9pbnRlcgo+ICAgKiBAdHlwZTogYW1kZ3B1X3Jpbmdf dHlwZSBlbnVtCj4gKyAqIEBibGFja2xpc3Q6IGJsYWNrbGlzdGVkIHJpbmcgaWRzIGFycmF5Cj4g KyAqIEBudW1fYmxhY2tsaXN0OiBudW1iZXIgb2YgZW50cmllcyBpbiBAYmxhY2tsaXN0Cj4gICAq IEByaW5nOiBvdXRwdXQgcmluZwo+ICAgKgo+ICAgKiBSZXRyaWV2ZSB0aGUgYW1kZ3B1X3Jpbmcg c3RydWN0dXJlIGZvciB0aGUgbGVhc3QgcmVjZW50bHkgdXNlZCByaW5nIG9mCj4gICAqIGEgc3Bl Y2lmaWMgSVAgYmxvY2sgKGFsbCBhc2ljcykuCj4gICAqIFJldHVybnMgMCBvbiBzdWNjZXNzLCBl cnJvciBvbiBmYWlsdXJlLgo+ICAgKi8KPiAtaW50IGFtZGdwdV9yaW5nX2xydV9nZXQoc3RydWN0 IGFtZGdwdV9kZXZpY2UgKmFkZXYsIGludCB0eXBlLAo+IC0JCQlzdHJ1Y3QgYW1kZ3B1X3Jpbmcg KipyaW5nKQo+ICtpbnQgYW1kZ3B1X3JpbmdfbHJ1X2dldChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAq YWRldiwgaW50IHR5cGUsIGludCAqYmxhY2tsaXN0LAo+ICsJCQlpbnQgbnVtX2JsYWNrbGlzdCwg c3RydWN0IGFtZGdwdV9yaW5nICoqcmluZykKPiAgewo+ICAJc3RydWN0IGFtZGdwdV9yaW5nICpl bnRyeTsKPgo+ICAJLyogTGlzdCBpcyBzb3J0ZWQgaW4gTFJVIG9yZGVyLCBmaW5kIGZpcnN0IGVu dHJ5IGNvcnJlc3BvbmRpbmcKPiAgCSAqIHRvIHRoZSBkZXNpcmVkIEhXIElQICovCj4gIAkqcmlu ZyA9IE5VTEw7Cj4gIAlzcGluX2xvY2soJmFkZXYtPnJpbmdfbHJ1X2xpc3RfbG9jayk7Cj4gIAls aXN0X2Zvcl9lYWNoX2VudHJ5KGVudHJ5LCAmYWRldi0+cmluZ19scnVfbGlzdCwgbHJ1X2xpc3Qp IHsKPiAtCQlpZiAoZW50cnktPmZ1bmNzLT50eXBlID09IHR5cGUpIHsKPiAtCQkJKnJpbmcgPSBl bnRyeTsKPiAtCQkJYW1kZ3B1X3JpbmdfbHJ1X3RvdWNoX2xvY2tlZChhZGV2LCAqcmluZyk7Cj4g LQkJCWJyZWFrOwo+IC0JCX0KPiArCQlpZiAoZW50cnktPmZ1bmNzLT50eXBlICE9IHR5cGUpCj4g KwkJCWNvbnRpbnVlOwo+ICsKPiArCQlpZiAoYW1kZ3B1X3JpbmdfaXNfYmxhY2tsaXN0ZWQoZW50 cnksIGJsYWNrbGlzdCwgbnVtX2JsYWNrbGlzdCkpCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiArCQkq cmluZyA9IGVudHJ5Owo+ICsJCWFtZGdwdV9yaW5nX2xydV90b3VjaF9sb2NrZWQoYWRldiwgKnJp bmcpOwo+ICsJCWJyZWFrOwo+ICAJfQo+ICAJc3Bpbl91bmxvY2soJmFkZXYtPnJpbmdfbHJ1X2xp c3RfbG9jayk7Cj4KPiAgCWlmICghKnJpbmcpIHsKPiAgCQlEUk1fRVJST1IoIlJpbmcgTFJVIGNv bnRhaW5zIG5vIGVudHJpZXMgZm9yIHJpbmcgdHlwZTolZFxuIiwgdHlwZSk7Cj4gIAkJcmV0dXJu IC1FSU5WQUw7Cj4gIAl9Cj4KPiAgCXJldHVybiAwOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yaW5nLmggYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfcmluZy5oCj4gaW5kZXggMmM4MDFhNS4uODExZDc2YSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcmluZy5oCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3JpbmcuaAo+IEBAIC0xOTUsMTUgKzE5NSwx NSBAQCB2b2lkIGFtZGdwdV9yaW5nX2dlbmVyaWNfcGFkX2liKHN0cnVjdCBhbWRncHVfcmluZyAq cmluZywgc3RydWN0IGFtZGdwdV9pYiAqaWIpOwo+ICB2b2lkIGFtZGdwdV9yaW5nX2NvbW1pdChz dHJ1Y3QgYW1kZ3B1X3JpbmcgKnJpbmcpOwo+ICB2b2lkIGFtZGdwdV9yaW5nX3VuZG8oc3RydWN0 IGFtZGdwdV9yaW5nICpyaW5nKTsKPiAgaW50IGFtZGdwdV9yaW5nX3ByaW9yaXR5X2dldChzdHJ1 Y3QgYW1kZ3B1X3JpbmcgKnJpbmcsCj4gIAkJCSAgICAgZW51bSBhbWRfc2NoZWRfcHJpb3JpdHkg cHJpb3JpdHkpOwo+ICB2b2lkIGFtZGdwdV9yaW5nX3ByaW9yaXR5X3B1dChzdHJ1Y3QgYW1kZ3B1 X3JpbmcgKnJpbmcsCj4gIAkJCSAgICAgIGVudW0gYW1kX3NjaGVkX3ByaW9yaXR5IHByaW9yaXR5 KTsKPiAgaW50IGFtZGdwdV9yaW5nX2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHN0 cnVjdCBhbWRncHVfcmluZyAqcmluZywKPiAgCQkgICAgIHVuc2lnbmVkIHJpbmdfc2l6ZSwgc3Ry dWN0IGFtZGdwdV9pcnFfc3JjICppcnFfc3JjLAo+ICAJCSAgICAgdW5zaWduZWQgaXJxX3R5cGUp Owo+ICB2b2lkIGFtZGdwdV9yaW5nX2Zpbmkoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nKTsKPiAt aW50IGFtZGdwdV9yaW5nX2xydV9nZXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIGludCBo d19pcCwKPiAtCQkJc3RydWN0IGFtZGdwdV9yaW5nICoqcmluZyk7Cj4gK2ludCBhbWRncHVfcmlu Z19scnVfZ2V0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCBpbnQgdHlwZSwgaW50ICpibGFj a2xpc3QsCj4gKwkJCWludCBudW1fYmxhY2tsaXN0LCBzdHJ1Y3QgYW1kZ3B1X3JpbmcgKipyaW5n KTsKPiAgdm9pZCBhbWRncHVfcmluZ19scnVfdG91Y2goc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk ZXYsIHN0cnVjdCBhbWRncHVfcmluZyAqcmluZyk7Cj4KPiAgI2VuZGlmCj4KCgotLSAKTGVybmUs IHdpZSBkaWUgV2VsdCB3aXJrbGljaCBpc3QsCkFiZXIgdmVyZ2lzcyBuaWVtYWxzLCB3aWUgc2ll IHNlaW4gc29sbHRlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK