From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 394FFC388F9 for ; Wed, 11 Nov 2020 12:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEDAE2068D for ; Wed, 11 Nov 2020 12:46:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="r9nWEq3/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbgKKMqf (ORCPT ); Wed, 11 Nov 2020 07:46:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:48938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbgKKMqe (ORCPT ); Wed, 11 Nov 2020 07:46:34 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2AA520709; Wed, 11 Nov 2020 12:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605098793; bh=fgvFar5VH6U4VmS5tTBAQ11UfAbcAq37UA/xmP7e4uI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r9nWEq3/jfTwQEjDuIXAGQ3H5G3m3fz1i1Uank6++ovoprns/8F8c+AJfmJKnfkV7 U9NlWyNw0S5q4V2xcpf3b2+tlqT2T4LDiaqsi1VnqngsXR8NZmG4TrZwTzJ7CAHd82 DHwKVfdZtvolrjK4/t4Wre1aIEKeFreUOxIC7ckM= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kcpWA-009lDZ-KI; Wed, 11 Nov 2020 12:46:30 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 11 Nov 2020 12:46:30 +0000 From: Marc Zyngier To: David Brazdil Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Morse , Julien Thierry , Suzuki K Poulose , Catalin Marinas , Will Deacon , Dennis Zhou , Tejun Heo , Christoph Lameter , Mark Rutland , Lorenzo Pieralisi , Quentin Perret , Andrew Scull , Andrew Walbran , kernel-team@android.com Subject: Re: [PATCH v1 06/24] kvm: arm64: Support per_cpu_ptr in nVHE hyp code In-Reply-To: <20201111123222.ooevu6nryu3ncphv@google.com> References: <20201109113233.9012-1-dbrazdil@google.com> <20201109113233.9012-7-dbrazdil@google.com> <20201111123222.ooevu6nryu3ncphv@google.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <52b47a4284aaff2e198385ef9acbe01f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: dbrazdil@google.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, qperret@google.com, ascull@google.com, qwandor@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-11 12:32, David Brazdil wrote: >> > + >> > + cpu_base_array = kern_hyp_va(&kvm_arm_hyp_percpu_base[0]); >> >> There is no guarantee that this will not generate a PC relative >> addressing, resulting in kern_hyp_va() being applied twice. >> >> Consider using hyp_symbol_addr() instead, which always does the right >> by forcing a PC relative addressing and not subsequently mangling >> the address. >> >> > + this_cpu_base = kern_hyp_va(cpu_base_array[cpu]); >> > + return this_cpu_base - (unsigned long)&__per_cpu_start; >> >> And this is the opposite case: if the compiler generates an absolute >> address, you're toast. Yes, this is just as unlikely, but hey... >> Same remedy should apply. > > Good point, and I'll probably keep forgetting about this in the future. > Now > that all .hyp.text is only executed under hyp page tables, should we > start > thinking about fixing up the relocations? Why not, if you can deal with the hypervisor text being mapped at a random location, and make sure that the kernel doesn't process the relocations for you. This would certainly save us a lot of runtime offsetting (which I'm adding to in a separate series). M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC885C5517A for ; Wed, 11 Nov 2020 12:46:40 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id E7B65206F1 for ; Wed, 11 Nov 2020 12:46:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="r9nWEq3/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7B65206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5254A4B7D7; Wed, 11 Nov 2020 07:46:39 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b65Fd7y2v0FN; Wed, 11 Nov 2020 07:46:36 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A57184B929; Wed, 11 Nov 2020 07:46:36 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4829E4B7D9 for ; Wed, 11 Nov 2020 07:46:35 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qr86RXqt+f74 for ; Wed, 11 Nov 2020 07:46:34 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 459C84B7CF for ; Wed, 11 Nov 2020 07:46:34 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2AA520709; Wed, 11 Nov 2020 12:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605098793; bh=fgvFar5VH6U4VmS5tTBAQ11UfAbcAq37UA/xmP7e4uI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r9nWEq3/jfTwQEjDuIXAGQ3H5G3m3fz1i1Uank6++ovoprns/8F8c+AJfmJKnfkV7 U9NlWyNw0S5q4V2xcpf3b2+tlqT2T4LDiaqsi1VnqngsXR8NZmG4TrZwTzJ7CAHd82 DHwKVfdZtvolrjK4/t4Wre1aIEKeFreUOxIC7ckM= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kcpWA-009lDZ-KI; Wed, 11 Nov 2020 12:46:30 +0000 MIME-Version: 1.0 Date: Wed, 11 Nov 2020 12:46:30 +0000 From: Marc Zyngier To: David Brazdil Subject: Re: [PATCH v1 06/24] kvm: arm64: Support per_cpu_ptr in nVHE hyp code In-Reply-To: <20201111123222.ooevu6nryu3ncphv@google.com> References: <20201109113233.9012-1-dbrazdil@google.com> <20201109113233.9012-7-dbrazdil@google.com> <20201111123222.ooevu6nryu3ncphv@google.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <52b47a4284aaff2e198385ef9acbe01f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: dbrazdil@google.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, qperret@google.com, ascull@google.com, qwandor@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kernel-team@android.com, Lorenzo Pieralisi , Andrew Walbran , Catalin Marinas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tejun Heo , Dennis Zhou , Christoph Lameter , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2020-11-11 12:32, David Brazdil wrote: >> > + >> > + cpu_base_array = kern_hyp_va(&kvm_arm_hyp_percpu_base[0]); >> >> There is no guarantee that this will not generate a PC relative >> addressing, resulting in kern_hyp_va() being applied twice. >> >> Consider using hyp_symbol_addr() instead, which always does the right >> by forcing a PC relative addressing and not subsequently mangling >> the address. >> >> > + this_cpu_base = kern_hyp_va(cpu_base_array[cpu]); >> > + return this_cpu_base - (unsigned long)&__per_cpu_start; >> >> And this is the opposite case: if the compiler generates an absolute >> address, you're toast. Yes, this is just as unlikely, but hey... >> Same remedy should apply. > > Good point, and I'll probably keep forgetting about this in the future. > Now > that all .hyp.text is only executed under hyp page tables, should we > start > thinking about fixing up the relocations? Why not, if you can deal with the hypervisor text being mapped at a random location, and make sure that the kernel doesn't process the relocations for you. This would certainly save us a lot of runtime offsetting (which I'm adding to in a separate series). M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48FF9C388F9 for ; Wed, 11 Nov 2020 12:47:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2C62206F1 for ; Wed, 11 Nov 2020 12:47:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qid3FnAd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="r9nWEq3/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2C62206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d7KlRkHgwDa4Al5WkJ6Q6DJa2F6bl5jUDu0JJYy84VM=; b=qid3FnAdKN0+WMLv0vQR5N8ug a7eDwQlREcXabd44aIKkyUqha0PsVgFAIvwwuu5/GBSgCAz04+a9Fyp22bvtvYV0GGrBiy4HGPZ37 2uIwD0BaEWiXUPCd31U6ilxrVAKAO/ibxchHzSm1n5YkDnjGTSm6/TNrtNjlUqnEJ2TWVrhvazZN4 gSEm8/+qCIqek40QCF6PiHjO/JFzvIrA1UyVtU8ZhW0XLmFME1TKOEIHhsyORdOkdEhCdcdJfGpZh IgBtkweJTI7eZF14OS45VjM8KW+y6fnATLejNGvPyA0qi77p+KIYSuSZizVN7NNG4vVv+H7TKENGr EIV8EDAdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcpWH-0002u3-8x; Wed, 11 Nov 2020 12:46:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcpWD-0002tA-NB for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 12:46:34 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2AA520709; Wed, 11 Nov 2020 12:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605098793; bh=fgvFar5VH6U4VmS5tTBAQ11UfAbcAq37UA/xmP7e4uI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r9nWEq3/jfTwQEjDuIXAGQ3H5G3m3fz1i1Uank6++ovoprns/8F8c+AJfmJKnfkV7 U9NlWyNw0S5q4V2xcpf3b2+tlqT2T4LDiaqsi1VnqngsXR8NZmG4TrZwTzJ7CAHd82 DHwKVfdZtvolrjK4/t4Wre1aIEKeFreUOxIC7ckM= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kcpWA-009lDZ-KI; Wed, 11 Nov 2020 12:46:30 +0000 MIME-Version: 1.0 Date: Wed, 11 Nov 2020 12:46:30 +0000 From: Marc Zyngier To: David Brazdil Subject: Re: [PATCH v1 06/24] kvm: arm64: Support per_cpu_ptr in nVHE hyp code In-Reply-To: <20201111123222.ooevu6nryu3ncphv@google.com> References: <20201109113233.9012-1-dbrazdil@google.com> <20201109113233.9012-7-dbrazdil@google.com> <20201111123222.ooevu6nryu3ncphv@google.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <52b47a4284aaff2e198385ef9acbe01f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: dbrazdil@google.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, qperret@google.com, ascull@google.com, qwandor@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_074633_944004_18E256FD X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kernel-team@android.com, Lorenzo Pieralisi , Andrew Walbran , Suzuki K Poulose , Catalin Marinas , Quentin Perret , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Tejun Heo , Dennis Zhou , Christoph Lameter , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry , Andrew Scull Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-11-11 12:32, David Brazdil wrote: >> > + >> > + cpu_base_array = kern_hyp_va(&kvm_arm_hyp_percpu_base[0]); >> >> There is no guarantee that this will not generate a PC relative >> addressing, resulting in kern_hyp_va() being applied twice. >> >> Consider using hyp_symbol_addr() instead, which always does the right >> by forcing a PC relative addressing and not subsequently mangling >> the address. >> >> > + this_cpu_base = kern_hyp_va(cpu_base_array[cpu]); >> > + return this_cpu_base - (unsigned long)&__per_cpu_start; >> >> And this is the opposite case: if the compiler generates an absolute >> address, you're toast. Yes, this is just as unlikely, but hey... >> Same remedy should apply. > > Good point, and I'll probably keep forgetting about this in the future. > Now > that all .hyp.text is only executed under hyp page tables, should we > start > thinking about fixing up the relocations? Why not, if you can deal with the hypervisor text being mapped at a random location, and make sure that the kernel doesn't process the relocations for you. This would certainly save us a lot of runtime offsetting (which I'm adding to in a separate series). M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel