From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941762AbcJYQYZ (ORCPT ); Tue, 25 Oct 2016 12:24:25 -0400 Received: from vern.gendns.com ([206.190.152.46]:47237 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932543AbcJYQYU (ORCPT ); Tue, 25 Oct 2016 12:24:20 -0400 Subject: Re: [PATCH/RFT v2 11/17] USB: OHCI: make ohci-da8xx a separate driver To: Axel Haslam References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-12-ahaslam@baylibre.com> <403743d8-dff2-3389-105b-1082b674b0b8@lechnology.com> <21019d11-3b01-3e0e-60bc-c4873cf20237@lechnology.com> Cc: Greg KH , Johan Hovold , robh+dt@kernel.org, Sekhar Nori , Alan Stern , Kevin Hilman , Sergei Shtylyov , manjunath.goudar@linaro.org, Mark Brown , Alexandre Bailon , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: <52b6439e-2bb8-a9d0-da8c-93646b6ee4b0@lechnology.com> Date: Tue, 25 Oct 2016 11:24:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/2016 11:21 AM, Axel Haslam wrote: > On Tue, Oct 25, 2016 at 6:12 PM, David Lechner wrote: >> On 10/25/2016 02:39 AM, Axel Haslam wrote: >>> >>> On Tue, Oct 25, 2016 at 2:38 AM, David Lechner >>> wrote: >>>> >>>> On 10/24/2016 11:46 AM, ahaslam@baylibre.com wrote: >>>>> >>>>> >>>>> -#ifndef CONFIG_ARCH_DAVINCI_DA8XX >>>>> -#error "This file is DA8xx bus glue. Define >>>>> CONFIG_ARCH_DAVINCI_DA8XX." >>>>> -#endif >>>>> +#include "ohci.h" >>>>> + >>>>> +#define DRIVER_DESC "OHCI DA8XX driver" >>>>> + >>>>> +static const char hcd_name[] = "ohci-da8xx"; >>>> >>>> >>>> >>>> why static const char instead of #define? This is only used one time in a >>>> pr_info, so it seems kind of pointless anyway. >>> >>> >>> Other drivers are using static const for the same variable. >>> i think static const is preferred over #define because #define doet give a >>> type. >>> If you dont mind ill keep it static const. >>> >> >> If this string was used in this file more than one place, I would agree with >> you, but currently it is only used as the argument of a pr_info(). The >> string "ohci-da8xx" could just be included in the fmt string instead of >> using "%s". > > I think the purpose was to use it in the .name of the platform_driver > structure, too. only that not everybody is doing that, i looked at some bad > examples :( > > would you agree to keep it if we use it in .name too? > > -Axel > >> Yes, that will make more sense. ;-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lechner Subject: Re: [PATCH/RFT v2 11/17] USB: OHCI: make ohci-da8xx a separate driver Date: Tue, 25 Oct 2016 11:24:17 -0500 Message-ID: <52b6439e-2bb8-a9d0-da8c-93646b6ee4b0@lechnology.com> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-12-ahaslam@baylibre.com> <403743d8-dff2-3389-105b-1082b674b0b8@lechnology.com> <21019d11-3b01-3e0e-60bc-c4873cf20237@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Axel Haslam Cc: Greg KH , Johan Hovold , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Sekhar Nori , Alan Stern , Kevin Hilman , Sergei Shtylyov , manjunath.goudar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Mark Brown , Alexandre Bailon , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/25/2016 11:21 AM, Axel Haslam wrote: > On Tue, Oct 25, 2016 at 6:12 PM, David Lechner wrote: >> On 10/25/2016 02:39 AM, Axel Haslam wrote: >>> >>> On Tue, Oct 25, 2016 at 2:38 AM, David Lechner >>> wrote: >>>> >>>> On 10/24/2016 11:46 AM, ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org wrote: >>>>> >>>>> >>>>> -#ifndef CONFIG_ARCH_DAVINCI_DA8XX >>>>> -#error "This file is DA8xx bus glue. Define >>>>> CONFIG_ARCH_DAVINCI_DA8XX." >>>>> -#endif >>>>> +#include "ohci.h" >>>>> + >>>>> +#define DRIVER_DESC "OHCI DA8XX driver" >>>>> + >>>>> +static const char hcd_name[] = "ohci-da8xx"; >>>> >>>> >>>> >>>> why static const char instead of #define? This is only used one time in a >>>> pr_info, so it seems kind of pointless anyway. >>> >>> >>> Other drivers are using static const for the same variable. >>> i think static const is preferred over #define because #define doet give a >>> type. >>> If you dont mind ill keep it static const. >>> >> >> If this string was used in this file more than one place, I would agree with >> you, but currently it is only used as the argument of a pr_info(). The >> string "ohci-da8xx" could just be included in the fmt string instead of >> using "%s". > > I think the purpose was to use it in the .name of the platform_driver > structure, too. only that not everybody is doing that, i looked at some bad > examples :( > > would you agree to keep it if we use it in .name too? > > -Axel > >> Yes, that will make more sense. ;-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: david@lechnology.com (David Lechner) Date: Tue, 25 Oct 2016 11:24:17 -0500 Subject: [PATCH/RFT v2 11/17] USB: OHCI: make ohci-da8xx a separate driver In-Reply-To: References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-12-ahaslam@baylibre.com> <403743d8-dff2-3389-105b-1082b674b0b8@lechnology.com> <21019d11-3b01-3e0e-60bc-c4873cf20237@lechnology.com> Message-ID: <52b6439e-2bb8-a9d0-da8c-93646b6ee4b0@lechnology.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/25/2016 11:21 AM, Axel Haslam wrote: > On Tue, Oct 25, 2016 at 6:12 PM, David Lechner wrote: >> On 10/25/2016 02:39 AM, Axel Haslam wrote: >>> >>> On Tue, Oct 25, 2016 at 2:38 AM, David Lechner >>> wrote: >>>> >>>> On 10/24/2016 11:46 AM, ahaslam at baylibre.com wrote: >>>>> >>>>> >>>>> -#ifndef CONFIG_ARCH_DAVINCI_DA8XX >>>>> -#error "This file is DA8xx bus glue. Define >>>>> CONFIG_ARCH_DAVINCI_DA8XX." >>>>> -#endif >>>>> +#include "ohci.h" >>>>> + >>>>> +#define DRIVER_DESC "OHCI DA8XX driver" >>>>> + >>>>> +static const char hcd_name[] = "ohci-da8xx"; >>>> >>>> >>>> >>>> why static const char instead of #define? This is only used one time in a >>>> pr_info, so it seems kind of pointless anyway. >>> >>> >>> Other drivers are using static const for the same variable. >>> i think static const is preferred over #define because #define doet give a >>> type. >>> If you dont mind ill keep it static const. >>> >> >> If this string was used in this file more than one place, I would agree with >> you, but currently it is only used as the argument of a pr_info(). The >> string "ohci-da8xx" could just be included in the fmt string instead of >> using "%s". > > I think the purpose was to use it in the .name of the platform_driver > structure, too. only that not everybody is doing that, i looked at some bad > examples :( > > would you agree to keep it if we use it in .name too? > > -Axel > >> Yes, that will make more sense. ;-)